Set default plotting kwargs #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to set default plotting kwargs. 1. xincrease, yincrease deepending on .attrs["positive"]
dcherian
commented
Jun 19, 2020
| def wrapper(*args, **kwargs): | ||
| arguments = accessor._process_signature(func, args, kwargs, key_mappers) | ||
| result = func(**arguments) | ||
| final_func = extra_decorator(func) if extra_decorator else func |
Contributor
Author
There was a problem hiding this comment.
This is the only design I could think of but it seems a little complicated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
_plot_decoratorthat is used to set default kwargs when appropriate CF attributes are set.Right now it only looks for
positive="down"and setsxincrease, yincreaseappropriately.This only works when
xandyare explicitly specified. To work whenx=Noneory=Nonewe'll have to do our own autoguessing. This could be useful the y-axis isZorY(priority order) and xaxis isT,X(priority order). Will leave that for later.