[WIP] add DataTree.to_netcdf #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 25, 2021 11:26
jhamman
commented
Aug 25, 2021
jhamman
commented
Aug 25, 2021
jhamman
commented
Aug 25, 2021
jhamman
commented
Aug 25, 2021
TomNicholas
reviewed
Aug 25, 2021
TomNicholas
reviewed
Aug 25, 2021
There was a problem hiding this comment.
This is great, thanks @jhamman. The only thing I can think of to add would be some kind of test that netcdf -> xarray.DataTree -> netcdf roundtripping works. That would probably require committing a small data file though.
(This can of course wait for another PR though)
jhamman
commented
Aug 25, 2021
jhamman
commented
Aug 25, 2021
TomNicholas
requested changes
Aug 25, 2021
Co-authored-by: Tom Nicholas <35968931+TomNicholas@users.noreply.github.com>
TomNicholas
reviewed
Aug 25, 2021
TomNicholas
reviewed
Aug 25, 2021
|
@TomNicholas - I think this is ready to go. I've special cased the empty node in read and write now. Easy to update in the future if the data model evolves a bit. |
TomNicholas
approved these changes
Aug 25, 2021
There was a problem hiding this comment.
Excellent @jhamman - thank you!
I might make minor changes (e.g. call a dedicated assert_tree_equal function) later, but this looks solid for now :)
Closed
Closed
flamingbear
pushed a commit
to flamingbear/rewritten-datatree
that referenced
this pull request
Jan 19, 2024
* first attempt at to_netcdf * lint * add test for roundtrip and support empty nodes * Apply suggestions from code review Co-authored-by: Tom Nicholas <35968931+TomNicholas@users.noreply.github.com> * update roundtrip test, improves empty node handling in IO Co-authored-by: Tom Nicholas <35968931+TomNicholas@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #16.
I've filled in
_datatree_to_netcdfto support writing aDataTreeto aNETCDF4file. I have a few questions for @TomNicholas that I'll highlight with comments on the changes.