Fix saving output variables with dtype=object #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able dtype is object or np.object. It works at runtime and the variable is successfully saved in the Dataset, but it fails at sabing to file xarray-contrib#144
benbovy
reviewed
Nov 12, 2020
There was a problem hiding this comment.
Thanks for submitting this @bgailleton !
I left two suggestions below.
Could you please add a unit test for this, as well as a new entry in the release notes (in docs)?
Py37 tests are failing but it is not related to the changes here.
benbovy
changed the title
benbovy
changed the title
|
LGTM, I pushed some commits to update an existing test for this. Thanks again @bgailleton! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…able dtype is object or np.object. It works at runtime and the variable is successfully saved in the Dataset, but it fails at sabing to file Closes #144
black . && flake8whats-new.rstfor all changes andapi.rstfor new API