From a6bf5da756c505be6262c05c8b34abbd1749a004 Mon Sep 17 00:00:00 2001 From: Brendan Collins Date: Thu, 21 May 2026 13:43:40 -0700 Subject: [PATCH] Drop lz4 from byte-parity sweep, gated as experimental (#2268) `lz4` moved into `_EXPERIMENTAL_CODECS` via #2137, so direct callers must now pass `allow_experimental_codecs=True`. The parity sweep in `test_lowlevel_write_pushdown_2138.py` calls `_write` and `to_geotiff` without the opt-in and was failing at the gate. The other experimental codecs (`lerc`, `jpeg2000`, `j2k`) are already absent from `_PARITY_CODECS`. Removing `lz4` keeps the list consistent with the docstring's "stable lossless codec set" framing. Closes #2268. --- .../geotiff/tests/test_lowlevel_write_pushdown_2138.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/xrspatial/geotiff/tests/test_lowlevel_write_pushdown_2138.py b/xrspatial/geotiff/tests/test_lowlevel_write_pushdown_2138.py index 57c604c3e..1d4431909 100644 --- a/xrspatial/geotiff/tests/test_lowlevel_write_pushdown_2138.py +++ b/xrspatial/geotiff/tests/test_lowlevel_write_pushdown_2138.py @@ -266,16 +266,18 @@ def test_write_promotes_bool(self, tmp_path): # JPEG omitted from the byte-parity sweep on purpose: it requires the # opt-in, which the wrapper emits a runtime warning for, and JPEG is -# lossy so trivial seed changes can shift bytes. ``_write`` is exercised -# elsewhere; the parity sweep covers the lossless codec set that direct -# callers reach for first. +# lossy so trivial seed changes can shift bytes. The experimental codecs +# (``lerc``, ``jpeg2000`` / ``j2k``, ``lz4``) are gated behind +# ``allow_experimental_codecs=True`` (issue #2137) and are likewise +# excluded from this sweep. ``_write`` is exercised elsewhere; the +# parity sweep covers the stable lossless codec set that direct callers +# reach for first. _PARITY_CODECS = ( "none", "deflate", "lzw", "packbits", "zstd", - "lz4", )