Split SUPPORTED_FEATURES into writer.cog / reader.local_cog / reader.http_cog (#2291)#2295
Merged
brendancol merged 2 commits intoMay 22, 2026
Conversation
…reader keys (xarray-contrib#2291) Foundational, no behaviour change. Adds reader.local_cog and reader.http_cog alongside the existing writer.cog so the three COG code paths can move between tiers on independent tracks. Production code still gates on the underlying writer / reader options; the keys are inventory only. Extends the existing tier inventory test to pin the three keys.
Contributor
Author
PR ReviewInventory-only change, scoped tightly to what #2291 asks for. Two new reader keys, one updated block comment, one new test. Nothing else touched. BlockersNone. SuggestionsNone. Nits
What looks good
ChecklistAlmost everything in the standard checklist is n/a for an inventory-only change. The two items that do apply both pass:
|
Contributor
Author
Re-review (round 2)Picked up the one nit from the first pass. The inline comment at Diff is otherwise unchanged from round 1. No new findings. Marking the review clean from my side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2291. Part of the #2286 COG readiness rollout.
What changed
xrspatial/geotiff/_attrs.py: addsreader.local_cogandreader.http_cogtoSUPPORTED_FEATURESat theadvancedtier.writer.cogkeeps its current tier. The comment block above the dict picks up a short note on why the three keys are separate.xrspatial/geotiff/tests/test_supported_features_tiers_2137.py: small inventory test that asserts the three keys exist and carry a known tier label.What did not change
Why the split
The three COG code paths have separate stability profiles. The writer emits a self-contained COG layout, the local reader walks overview IFDs on disk, and the HTTP reader sits on top of range-request fetching and partial-IFD handling. Folding them under one key would tie any promotion of one path to a promotion of all three.
Test plan
pytest xrspatial/geotiff/tests/passes locally (5118 passed, 68 skipped).