geotiff tests: consolidate sidecar cluster (#2436)#2466
Merged
Conversation
Fold the six top-level sidecar files into a new integration/test_sidecar.py, one Section per source issue: - test_sidecar_ovr_2112.py - test_sidecar_own_geokeys_2315.py - test_sidecar_max_cloud_bytes_2121.py - test_sidecar_bad_does_not_break_base_2416.py - test_remote_sidecar_chunked_2239.py - test_remote_sidecar_byte_order_2314.py Colliding module helpers are namespaced per source issue and GPU gating moves to the shared requires_gpu marker. The golden_corpus fixture path resolves against the tests directory now that the file lives one level deeper. No assertion changed; 64 test functions (83 collected) match the pre-consolidation total. test_gpu_sidecar_georef_parity_2324.py imported _write_pair from the own-geokeys file; the import now points at the consolidated module. The release-gate checklist and geotiff docs cite the new path so the checklist-parity gate stays green. Sub-PR A of issue #2436 (cluster 12, long-tail epic #2424). Tests-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2436 (Sub-PR A of two). Cluster 12 of the long-tail GeoTIFF test consolidation epic (#2424). Tests-only.
Summary
Merges six top-level sidecar files into a new
xrspatial/geotiff/tests/integration/test_sidecar.py, one Section per source issue:test_sidecar_ovr_2112.pytest_sidecar_own_geokeys_2315.pytest_sidecar_max_cloud_bytes_2121.pytest_sidecar_bad_does_not_break_base_2416.pytest_remote_sidecar_chunked_2239.pytest_remote_sidecar_byte_order_2314.pyModule helpers that collided across sources are namespaced per source issue, and GPU gating moves to the shared
requires_gpumarker from_helpers/markers.py. The bundledgolden_corpusfixture path now resolves against thetestsdirectory since the file sits one level deeper inintegration/. No assertion changed; 64 test functions (83 collected) match the pre-consolidation total.test_gpu_sidecar_georef_parity_2324.pyimported_write_pairfrom the own-geokeys file, so that import now points at the consolidated module. The release-gate checklist (release_gate_geotiff.rst) and the geotiff docs cite the new path so the checklist-parity gate stays green.Audit
CLUSTER_AUDIT_SIDECAR.mdmaps every oldfile::testto its new home. It is deleted on a final commit before merge per the epic hard gate.Verification
pytest xrspatial/geotiff/tests/integration/test_sidecar.py xrspatial/geotiff/tests/test_gpu_sidecar_georef_parity_2324.py -q: 86 passed.pytest xrspatial/geotiff/tests/ --co -q: 5890 tests collected.Test plan
integration/test_sidecar.pypasses on this checkout.