Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync setup.cfg with .pre-commit-config.yaml #323

Merged
merged 1 commit into from
May 17, 2021

Conversation

raybellwaves
Copy link
Member

Keep setup.cfg inline with .pre-commit-config.yaml

We leave most of the CI to pre-commit / GHA but this helps match the settings if a developer want to run one tool locally e.g. mypy

@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #323 (b06eaab) into main (1f9270c) will decrease coverage by 0.06%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #323      +/-   ##
==========================================
- Coverage   94.58%   94.51%   -0.07%     
==========================================
  Files          23       23              
  Lines        2604     2626      +22     
==========================================
+ Hits         2463     2482      +19     
- Misses        141      144       +3     
Impacted Files Coverage Δ
xskillscore/core/comparative.py 91.20% <88.57%> (-2.22%) ⬇️
xskillscore/__init__.py 84.61% <100.00%> (ø)
xskillscore/tests/test_comparative.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0851c87...b06eaab. Read the comment docs.

@raybellwaves
Copy link
Member Author

@aaronspring hope you don't mind me merging here. I think for small change this we need not bother the other person for approval.

@raybellwaves raybellwaves merged commit 0620de0 into xarray-contrib:main May 17, 2021
@raybellwaves raybellwaves deleted the sync-setup.cfg branch May 17, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant