Permalink
Browse files

Remove the metric_fu quality dependency and tasks

We've found too many issues with having metric_fu
and its minions as our development dependency and
it's easier to just drop them then to figure out how
to fix it. If one wants to run code quality checks
on the codebase it's obviously still possible but
you need to handle deps installation on your own.

What were the problems?

1)
with metric_fu along with roodi etc in the gemfile
bundling takes forever (ok, it takes about 40-60
minutes)

2)
if we leave only metric_fu as the dep (which depends
on roodi etc. anyway) we will get latest versions
of the gems which unfortunatelly results with a weird
error when running semipublic specs so we need to
pin the versions which gets us back to the problem #1
  • Loading branch information...
1 parent 8671442 commit d607bcf7e9ef43a1b85504f559631e9ae3f75570 @snusnu snusnu committed Nov 4, 2010
Showing with 0 additions and 40 deletions.
  1. +0 −3 Gemfile
  2. +0 −1 tasks/ci.rake
  3. +0 −36 tasks/metrics.rake
View
@@ -97,10 +97,7 @@ end
group :quality do # These gems contain rake tasks that check the quality of the source code
- gem 'metric_fu', '~> 1.3'
gem 'rcov', '~> 0.9.8'
- gem 'reek', '~> 1.2.8'
- gem 'roodi', '~> 2.1'
gem 'yard', '~> 0.5'
gem 'yardstick', '~> 0.1'
View
@@ -1 +0,0 @@
-task :ci => [ :verify_measurements, 'metrics:all' ]
View
@@ -1,36 +0,0 @@
-begin
- require 'metric_fu'
-rescue LoadError
- namespace :metrics do
- task :all do
- abort 'metric_fu is not available. In order to run metrics:all, you must: gem install metric_fu'
- end
- end
-end
-
-begin
- require 'reek/adapters/rake_task'
-
- Reek::RakeTask.new do |t|
- t.fail_on_error = true
- t.verbose = false
- t.source_files = 'lib/**/*.rb'
- end
-rescue LoadError
- task :reek do
- abort 'Reek is not available. In order to run reek, you must: gem install reek'
- end
-end
-
-begin
- require 'roodi'
- require 'roodi_task'
-
- RoodiTask.new do |t|
- t.verbose = false
- end
-rescue LoadError
- task :roodi do
- abort 'Roodi is not available. In order to run roodi, you must: gem install roodi'
- end
-end

0 comments on commit d607bcf

Please sign in to comment.