Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Commits on Sep 22, 2015
  1. @gaelian

    Updated gems.

    gaelian committed
  2. @gaelian
  3. @gaelian

    Convert specs to RSpec 3.3.2 syntax with Transpec.

    gaelian committed
    This conversion is done by Transpec 3.1.1 with the following command:
    * 254 conversions
        from: obj.should
          to: expect(obj).to
    * 132 conversions
        from: == expected
          to: eq(expected)
    * 89 conversions
        from: obj.stub(:message)
          to: allow(obj).to receive(:message)
    * 32 conversions
        from: obj.should_not
          to: expect(obj).not_to
    * 30 conversions
        from: obj.should_receive(:message)
          to: expect(obj).to receive(:message)
    * 6 conversions
        from: lambda { }.should
          to: expect { }.to
    * 2 conversions
        from: it { should_not ... }
          to: it { is_expected.not_to ... }
    * 1 conversion
        from: it { should ... }
          to: it { ... }
    * 1 conversion
        from: lambda { }.should_not
          to: expect { }.not_to
    * 1 conversion
        from: obj.stub_chain(:message1, :message2)
          to: allow(obj).to receive_message_chain(:message1, :message2)
    For more details:
Commits on Sep 21, 2015
  1. @gaelian
Commits on Sep 4, 2015
  1. @gaelian

    Temp fix for rspec-activemodel-mocks gem.

    gaelian committed
    Fix for current compatibility issue with Rails 4.2.x and
    rspec-activemodel-mocks. Should be able to go back to the standard
    rspec-activemodel-mocks gem once this issue is resolved:
  2. @gaelian

    Updated to Rails 4.2.4.

    gaelian committed
Commits on Sep 2, 2015
  1. @gaelian

    Updated gems, fixed specs.

    gaelian committed
    Newer versions of rspec related stuff required some spec file updates.
    Added rspec-activemodel-mocks and rspec-collection_matchers gems to
    support previously written specs.
Commits on Apr 27, 2015
  1. @gaelian

    Fixed tag-related functionality.

    gaelian committed
    Fixed the long standing issue where tags that are only related to
    unpublished posts are still shown in navigation by way of the
    NavigationHelper#category_links_for_navigation helper method. Now making
    use of the cached_tag_list attribute on the Post model in order to
    reduce the number of database queries generated by the
    NavigationHelper#category_links_for_navigation helper method.
    Removed NavigationHelper#class_for_tab helper method as it does not
    appear to be used anywhere.
    Fixed/updated specs and reverted back to previous behaviour where a
    request for an unpublished tag will result in an
    ActiveRecord::RecordNotFound exception.
    Also minor code clean up for consistency/readability.
  2. @gaelian
Commits on Apr 26, 2015
  1. @gaelian
  2. @gaelian
Commits on Apr 19, 2015
  1. @gaelian

    Code clean up.

    gaelian committed
Commits on Apr 17, 2015
  1. @gaelian
  2. @gaelian

    Fixed author_google_oauth2_email method.

    gaelian committed
    The author_google_oauth2_email method should return a string, not a
    string inside an array.
  3. @gaelian
Commits on Apr 16, 2015
  1. @gaelian
  2. @gaelian
  3. @gaelian

    Switched to OmniAuth for authentication.

    gaelian committed
    The open_id_authentication gem is no longer used. This commit includes a
    migration that removes the two tables used by the open_id_authentication
    gem (i.e. the open_id_authentication_nonces and
    open_id_authentication_associations tables).
    Enki now supports Google OpenID Connect (OAuth 2.0 for Login) and OpenID
    2.0 by default. But further OmniAuth strategies can be added if desired.
    Closes #97.
Commits on Dec 2, 2013
  1. Merge pull request #96 from clok/page_creation

    Update Page Creation for Rails 4
Commits on Dec 1, 2013
  1. @clok

    updated rspec test

    clok committed
  2. @clok
Commits on Oct 15, 2013
  1. Merge pull request #94 from gaelian/dot-in-tag-name-fix

    Fixed incorrect tag name behaviour.
  2. Merge pull request #95 from gaelian/post-preview-fix

    Fixed post preview feature.
  3. @gaelian

    Fixed post preview feature.

    gaelian committed
    The posts preview feature was broken by the advent of Rails 4 strong
    params. This commit restores the feature back to working order.
    Updated specs.
  4. @gaelian

    Filter tag names to contain only expected chars.

    gaelian committed
    Tag names can now only contain alphanumeric, underscore, space, dot and
    dash characters. Other characters will be filtered out, ampersands will
    be expanded to 'and'. This limitation has been enforced to avoid
    complications with routing where tag names are involved.
    Updated specs accordingly.
  5. @gaelian

    Updated for spacing consistency.

    gaelian committed
Commits on Oct 12, 2013
  1. @gaelian

    Addressed broken Atom format.

    gaelian committed
    Tags can now be viewed in HTML and Atom format regardless of whether the
    tag name contains a dot character or not. The regular expression that
    matches tag names currently allows upper/lower case letters, numbers,
    dots, dashes, underscores and spaces (URL encoded or not).
    Updated relevant specs. Moved routing specs into posts_routing_spec.rb
    as this seems like a more fitting place for them.
  2. @gaelian

    Fixed incorrect tag name behaviour.

    gaelian committed
    When a tag name contains a dot character, Rails interprets this as the
    separator for a formatted route and splits the tag name into the section
    before the dot which is interpreted as the expected :tag parameter, and
    the section after the dot which is interpreted as an unexpected :format
    This commit restores correct behaviour in the event that a tag name
    contains a dot character and includes spec coverage.
    Fixes #93.
Commits on Oct 7, 2013
  1. Merge pull request #92 from gaelian/openid-login-fix

    Applied fix for logging in via OpenID to the admin area.
Commits on Oct 6, 2013
  1. @gaelian

    Applied fix for logging in via OpenID to the admin area.

    gaelian committed
    Rails now contains code that resets the session if the CSRF request
    forgery check fails. This was happening on the OpenID callback when
    logging in to the Enki admin area, which broke OpenID login.
    This commit disables the CSRF check only for OpenID callbacks when
    logging in to the Enki admin area.
    Fixes #91.
Commits on Sep 29, 2013
  1. Merge pull request #90 from gaelian/strong-params-fix

    Whitelisting parameters required for successful display of posts.
Commits on Sep 28, 2013
  1. @gaelian

    Spec coverage for Rails 4 strong params functionality.

    gaelian committed
    Added factory_girl factories for use with update specs on:
  2. @gaelian

    Fixes related to correct whitelisting of attributes for comments.

    gaelian committed
    Start making use of the comment_params method in
    Removed author_url and author_email from the params whitelist in
    comments_controller.rb as according to the spec, these should not be
    able to be set from the front end anyway.
Commits on Sep 22, 2013
  1. @gaelian

    Whitelisting parameters required for successful display of posts.

    gaelian committed
    The move to Rails 4 and strong parameters necessitates whitelisting of
    parameters being processed by the controller. The exclusion of the
    :tag_list, :published_at_natural and :slug parameters from the
    whitelist means that these data are not being saved to the db and hence
    no new post will be displayed on the front end, no new tags will be
    saved and the post slug cannot be updated after initial creation. This
    commit fixes these issues.
Commits on Jul 23, 2013
  1. Merge pull request #88 from gaelian/ifnull-fix

    Changed SQL function call ifnull() to coalesce().
Something went wrong with that request. Please try again.