Skip to content
This repository
branch: master

Dec 02, 2013

  1. Xavier Shay

    Merge pull request #96 from clok/page_creation

    Update Page Creation for Rails 4
    authored

Dec 01, 2013

  1. updated rspec test

    authored
  2. updated admin/pages_controller.rb for Rails 4

    authored

Oct 15, 2013

  1. Xavier Shay

    Merge pull request #94 from gaelian/dot-in-tag-name-fix

    Fixed incorrect tag name behaviour.
    authored
  2. Xavier Shay

    Merge pull request #95 from gaelian/post-preview-fix

    Fixed post preview feature.
    authored
  3. Gaelian Ditchburn

    Fixed post preview feature.

    The posts preview feature was broken by the advent of Rails 4 strong
    params. This commit restores the feature back to working order.
    
    Updated specs.
    authored
  4. Gaelian Ditchburn

    Filter tag names to contain only expected chars.

    Tag names can now only contain alphanumeric, underscore, space, dot and
    dash characters. Other characters will be filtered out, ampersands will
    be expanded to 'and'. This limitation has been enforced to avoid
    complications with routing where tag names are involved.
    
    Updated specs accordingly.
    authored
  5. Gaelian Ditchburn

    Updated for spacing consistency.

    authored

Oct 12, 2013

  1. Gaelian Ditchburn

    Addressed broken Atom format.

    Tags can now be viewed in HTML and Atom format regardless of whether the
    tag name contains a dot character or not. The regular expression that
    matches tag names currently allows upper/lower case letters, numbers,
    dots, dashes, underscores and spaces (URL encoded or not).
    
    Updated relevant specs. Moved routing specs into posts_routing_spec.rb
    as this seems like a more fitting place for them.
    authored
  2. Gaelian Ditchburn

    Fixed incorrect tag name behaviour.

    When a tag name contains a dot character, Rails interprets this as the
    separator for a formatted route and splits the tag name into the section
    before the dot which is interpreted as the expected :tag parameter, and
    the section after the dot which is interpreted as an unexpected :format
    parameter.
    
    This commit restores correct behaviour in the event that a tag name
    contains a dot character and includes spec coverage.
    
    Fixes #93.
    authored

Oct 07, 2013

  1. Xavier Shay

    Merge pull request #92 from gaelian/openid-login-fix

    Applied fix for logging in via OpenID to the admin area.
    authored

Oct 06, 2013

  1. Gaelian Ditchburn

    Applied fix for logging in via OpenID to the admin area.

    Rails now contains code that resets the session if the CSRF request
    forgery check fails. This was happening on the OpenID callback when
    logging in to the Enki admin area, which broke OpenID login.
    
    This commit disables the CSRF check only for OpenID callbacks when
    logging in to the Enki admin area.
    
    Fixes #91.
    authored

Sep 29, 2013

  1. Xavier Shay

    Merge pull request #90 from gaelian/strong-params-fix

    Whitelisting parameters required for successful display of posts.
    authored

Sep 28, 2013

  1. Gaelian Ditchburn

    Spec coverage for Rails 4 strong params functionality.

    Added factory_girl factories for use with update specs on:
    
    admin/comments_controller_spec.rb
    admin/posts_controller_spec.rb
    authored
  2. Gaelian Ditchburn

    Fixes related to correct whitelisting of attributes for comments.

    Start making use of the comment_params method in
    admin/comments_controller.rb.
    
    Removed author_url and author_email from the params whitelist in
    comments_controller.rb as according to the spec, these should not be
    able to be set from the front end anyway.
    authored

Sep 22, 2013

  1. Gaelian Ditchburn

    Whitelisting parameters required for successful display of posts.

    The move to Rails 4 and strong parameters necessitates whitelisting of
    parameters being processed by the controller. The exclusion of the
    :tag_list, :published_at_natural and :slug parameters from the
    whitelist means that these data are not being saved to the db and hence
    no new post will be displayed on the front end, no new tags will be
    saved and the post slug cannot be updated after initial creation. This
    commit fixes these issues.
    authored

Jul 23, 2013

  1. Xavier Shay

    Merge pull request #88 from gaelian/ifnull-fix

    Changed SQL function call ifnull() to coalesce().
    authored
  2. Gaelian Ditchburn

    Changed SQL function call ifnull() to coalesce().

    The SQL function ifnull() is not recognised by PostgreSQL and
    causes an error when Enki is used with PostgreSQL as the backend
    data store. Changing the call to coalesce() seems to work for
    both MySQL and PostgreSQL.
    authored

Jul 22, 2013

  1. Xavier Shay

    Merge pull request #85 from joneslee85/rails4

    Bump to Rails 4.
    authored
  2. Trung Lê

    Bump to Rails 4.

    [Closes #83]
    authored

Jul 20, 2013

  1. Xavier Shay

    Merge pull request #84 from joneslee85/patch-3

    Support Ruby 2
    authored
  2. Trung Lê

    Support Ruby 2

    * Bump to Rails 3.2.13 (known to support Ruby 2)
    * Remove Psych engine code
    * Fix tests related to YAML.load
    authored

Jul 18, 2013

  1. Xavier Shay

    Merge pull request #81 from joneslee85/patch-1

    Add Travis Status Badge [ci skip]
    authored
  2. Trung Lê

    Add Travis Status Badge [ci skip]

    authored
  3. Xavier Shay

    Merge pull request #82 from joneslee85/patch-2

    Test against Ruby 2.0
    authored
  4. Trung Lê

    Test against Ruby 2.0

    authored

Jul 10, 2013

  1. Xavier Shay

    Merge pull request #80 from RyanTG/master

    New textile manual link
    authored
  2. updated textile manual link

    authored

May 22, 2013

  1. Xavier Shay

    Merge pull request #79 from gaelian/raw-html-fix

    Fix addressing the issue where HTML is too eagerly escaped with relation to comments, pages and posts.
    authored
  2. Gaelian Ditchburn

    Fix addressing the issue where HTML is too eagerly escaped with

    relation to comments, pages and posts.
    authored

Apr 21, 2013

  1. Xavier Shay

    Merge pull request #77 from gaelian/superfluous-equals-signs

    Removed superfluous equals signs from ERB syntax.
    authored

Apr 20, 2013

  1. Gaelian Ditchburn

    Removed superfluous equals signs from ERB syntax.

    authored

Apr 18, 2013

  1. Xavier Shay

    Merge pull request #75 from mcary/allow-path-prefix

    Allow running Enki under a URL path prefix
    authored
  2. Tweak URL path prefix patch to address feedback from xaviershay

    When reviewing my pull request, xaviershay requested these changes:
    
    * Use ActionController::Base.config.relative_url_root instead of
      ENV['RAILS_RELATIVE_URL_ROOT'] in the UrlHelper and rackup.ru
    * Mention the feature in the README, because it won't be found in
      config/application.rb
    
    Implement these, but use Rails.configuration instead of
    ActionController::Base.config, as it seems like the current Rails best
    practice.
    authored
  3. Xavier Shay

    Merge pull request #73 from mcary/draft-posts

    Allow draft posts by special-casing blank published_at_natural
    authored
Something went wrong with that request. Please try again.