Subclass Module rather than having a giant builder method. #26

Merged
merged 1 commit into from Sep 28, 2012

2 participants

@myronmarston
Collaborator

The old way I implemented fire_class_double used Module.new with a giant block that defined lots of singleton methods. @avdi's talk at GoGaRuCo inspired me to subclass Module instead.

I find this cleaner, although it is a bit more code.

Thoughts?

@xaviershay
Owner

On the one hand I'm a little worried about doing something so non-standard, but on the other hand this code is totally nuts anyway :D Merging.

@xaviershay xaviershay merged commit 308ef46 into master Sep 28, 2012

1 check passed

Details default The Travis build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment