Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenSSL #6

Merged
merged 2 commits into from Oct 26, 2016

Conversation

@fetzerch
Copy link
Member

commented Oct 26, 2016

Followup on my questions in e5e4cee.

OpenSSL was really not installed neither on Jenkins nor locally. We always got a broken pipe error because all the following commands were just passed to make.
On Jenkins OSX, the Xcode version ships a local openssl library in default paths. On linux also the host lib is found.

fetzerch added 2 commits Oct 26, 2016
execute_command only takes one COMMAND argument. Therefore openssl
was not installed (make[6]: *** [install_sw] Broken pipe: 13).

Point librtmp to the right include directories in build/depends.
@notspiff notspiff merged commit 48742bc into xbmc:master Oct 26, 2016
@notspiff

This comment has been minimized.

Copy link

commented on 010d734 Oct 26, 2016

Wonder when execute process stopped eating multiple commands i am 100 that used to work.

This comment has been minimized.

Copy link
Owner Author

replied Oct 26, 2016

Hm. now i checked the docs and according to that it should be possible.
I know that i've fixed a similar issue earlier this year. Maybe it's just not possible to state WORKING_DIRECTORY twice.
No doubt that you tested it, just thought it changed somewhen in cmake.

This comment has been minimized.

Copy link

replied Oct 26, 2016

Sure and even if i didnt fix is fine but contrary to populat belief curiosity didnt actually kill that cat ;)

This comment has been minimized.

Copy link
Owner Author

replied Oct 26, 2016

Verified it, it's also not caused by removing WORKING_DIRECTORY. So either it's "install(CODE" and string weirdness, or a bug. But now let's see if I can get moonlight to compile :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.