update source code to use renamed platform pkg #16
Conversation
|
This one is similar: #13 ... Achieving it in different ways. |
|
@RobLoach , he did not update the control file, but if he did, it would be the same PR. |
|
👍 |
|
thanks! |
update source code to use renamed platform pkg
|
won't this affect any of our addons since none of the binary addons have been branch. |
|
I think so. What's next? |
|
either fix the addons or pull the kodi-platform revision before this PR. |
|
ok. before we bump revision: https://github.com/xbmc/xbmc/blob/f42c66f130805765b0c30d947980d5f2af847cde/project/cmake/addons/depends/common/kodi-platform/kodi-platform.txt |
|
yes, indeed. |
|
Branch as in create a Jarvis branch for addons and only bump kodi-platform for master? |
|
we need to branch the addons because they need adjustments for p8-platform |
|
But don't we need to adjust both Jarvis and future versions of addons? |
|
I don't think that Jarvis should get the new p8-platform |
|
Will the old version of libplatform still be packaged and shipped then? |
|
packaging libplatform is for convenience and only provided for some Linux distros. You always can build the addons with Kodi sources. those pull the correct version. |
|
If this is bad timing or otherwise, I'll ensure the SteamOS builds I do, use the legacy platform @ the commit before the rename upstream. Didn't mean to introduce trouble. |
|
Just so we don't duplicate work, I'm taking care of add-ons PRs now. |
|
@hudokkow , will this mean Jarvis will use p8-platform by release date? I am fine waiting. I'll just monitor this thread if that's ok for whatever the decision is. |
|
p8-platform and libplatform are identical codewise. it's just name changes to make some distributions happy. I'll publish binaries for Ubuntu on the PPA this week, then people can update things when they want to, but there's no rush. The two can sit next to each other. |
| @@ -21,7 +21,7 @@ | |||
| * | |||
| */ | |||
|
|
|||
| #include <platform/util/StdString.h> | |||
| #include <p8-platform/util/StdString.h> | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@ProfessorKaos64, not up to me to decide. There's a lot of updating/packaging involved. I'm just doing monkey work... 😉 |
|
the plan was to branch off addons for jarvis that still use the old libplatform. |
Upsteam renamed their package. After a few alternations to the kodi-platform source code, p8-platform can be integrated and used.
Test packages are built to the following locations for testing/evaluation:
http://packages.libregeek.org/SteamOS-Tools/pool/main/k/kodiplatform/