Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] windows build failures #115

Merged
merged 2 commits into from Jun 28, 2017

Conversation

@Rechi
Copy link
Member

commented Jun 28, 2017

  • TCHAR & TEXT identifiers don't start with an underscore
  • updated to C++ based addon interface for window

@garbear @AlwinEsch FYI

Rechi added 2 commits Jun 28, 2017
TCHAR & TEXT identifiers don't start with an underscore
introduced at 2e7c95f
@AlwinEsch AlwinEsch self-requested a review Jun 28, 2017
@Rechi

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2017

@AlwinEsch can this be merged or is there something wrong?

@AlwinEsch AlwinEsch merged commit 3ae0aee into master Jun 28, 2017
4 checks passed
4 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Rechi Rechi deleted the fixWindows branch Jun 28, 2017
@AlwinEsch

This comment has been minimized.

Copy link
Member

commented Jun 28, 2017

Is in, was waiting for @garbear :)

@Rechi

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2017

That was only to inform him about the wrong identifiers he introduced.

@garbear

This comment has been minimized.

Copy link
Member

commented Jun 28, 2017

I believe the underscores were for a macro that evaluated to wchar_t on unicode systems and char on non-unicode systems. I'll try compiling this on Windows 7 and see if it still works.

@garbear

This comment has been minimized.

Copy link
Member

commented Jun 28, 2017

Confirmed that this builds in my Windows 7 VM. I'll try actual hardware when I'm back from vacation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.