Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin.video.vimeo] 5.0.0 #2504

Merged
merged 1 commit into from Aug 30, 2019

Conversation

@jaylinski
Copy link
Contributor

commented Aug 26, 2019

Description

This is an incomplete rewrite of the original (and broken) plugin developed by bromix.

Since this is an update, the target is Krypton. If this is regarded as a new plugin, I will target it to Leia.

Features

  • Search videos
  • Featured videos
  • Backwards compatible /play/ API (sharing via Kore still works)
  • Python 3 compatibility (jaylinski/kodi-addon-vimeo#2)

Known issues

  • Login is not yet implemented
  • Settings are not backwards compatible (settings from v4 will be lost)

About this PR

  • This is my second plugin. Please review carefully.
  • Settings are not backwards compatible. I guess I could make some settings backwards compatible (like the search result length), but I think it's not worth the time.
  • Plugin is newly built from ground up, because of Python 3 compatibility
  • Login is still missing, but I think users prefer a plugin with basic functionality over a feature complete but broken plugin

Source

https://github.com/jaylinski/kodi-addon-vimeo

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0
@TravisBuddy

This comment has been minimized.

Copy link

commented Aug 26, 2019

Travis tests were successful

Hey @jaylinski,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@jaylinski jaylinski force-pushed the jaylinski:plugin.video.vimeo branch from 6c924f4 to c9a47f5 Aug 26, 2019

@TravisBuddy

This comment has been minimized.

Copy link

commented Aug 26, 2019

Travis tests were successful

Hey @jaylinski,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[![GitHub tag (latest SemVer)](https://img.shields.io/github/tag/jaylinski/kodi-addon-vimeo.svg)](https://github.com/jaylinski/kodi-addon-soundcloud/releases)
[![Build Status](https://travis-ci.com/jaylinski/kodi-addon-vimeo.svg?branch=master)](https://travis-ci.com/jaylinski/kodi-addon-vimeo)
[![Link to Kodi forum](https://img.shields.io/badge/Kodi-Forum-informational.svg)](https://forum.kodi.tv/showthread.php?tid=220437)
[![Link to Kodi wiki](https://img.shields.io/badge/Kodi-Wiki-informational.svg)](https://kodi.wiki/view/Add-on:Vimeo)

This comment has been minimized.

Copy link
@jaylinski

jaylinski Aug 27, 2019

Author Contributor

Do I have to update the wiki myself? https://kodi.wiki/view/Add-on:Vimeo
Everything but point 1 will be outdated as soon as this is merged.

This comment has been minimized.

Copy link
@enen92

enen92 Aug 27, 2019

Member

It would be nice if you could do that (after this is merged)

This comment has been minimized.

Copy link
@jaylinski

jaylinski Aug 27, 2019

Author Contributor

Ok, I requested an account.

@@ -0,0 +1,34 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<addon id="plugin.video.vimeo" name="Vimeo" version="5.0.0" provider-name="jaylinski">

This comment has been minimized.

Copy link
@enen92

enen92 Aug 27, 2019

Member

Are u using any of the old code from bromix? If so please add bromix also as an author

This comment has been minimized.

Copy link
@jaylinski

jaylinski Aug 27, 2019

Author Contributor

Nope, I only copied the Vimeo icon and fanart. The code is new.

There is an attribution section in the readme that mentions bromix.

@enen92

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

@jaylinski have you fully tested the add-on with python3? We have a build in the mirrors you could use: http://mirrors.kodi.tv/test-builds/windows/win64/KodiSetup-20190824-dda03937-PR16116-merge-x64.exe

@enen92

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

The Vimeo add-on in the helix branch needs to be marked as broken after this add-on goes in... ofc in case the add-on is in fact broken. Can you also do a PR for it?

@jaylinski jaylinski referenced this pull request Aug 27, 2019
3 of 3 tasks complete
@jaylinski

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

@jaylinski have you fully tested the add-on with python3? We have a build in the mirrors you could use: http://mirrors.kodi.tv/test-builds/windows/win64/KodiSetup-20190824-dda03937-PR16116-merge-x64.exe

@enen92 no. I'm developing on Ubuntu and failed to test Kodi in my Windows 10 virtual machine (something about a missing graphics lib). That's why I'm waiting for Linux builds (xbmc/xbmc#16116)

The Vimeo add-on in the helix branch needs to be marked as broken after this add-on goes in... ofc in case the add-on is in fact broken. Can you also do a PR for it?

@enen92 Ok, I created a PR: #2505
The plugin is broken for me, and seems to be broken for others (https://forum.kodi.tv/showthread.php?tid=220437&page=11)

@Rechi

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

I've done a quick test, the add-on is Python 3 compatible.

@enen92
enen92 approved these changes Aug 30, 2019

@enen92 enen92 merged commit d3c3b6e into xbmc:krypton Aug 30, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@enen92

This comment has been minimized.

Copy link
Member

commented Aug 30, 2019

Awesome. Please update the wiki if you find some time @jaylinski

@jaylinski

This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2019

Awesome. Please update the wiki if you find some time @jaylinski

Thanks! I updated the wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.