Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update] skin.phenomenal 4.2.3 #68

Closed
tomer953 opened this issue Apr 15, 2017 · 11 comments
Closed

[Update] skin.phenomenal 4.2.3 #68

tomer953 opened this issue Apr 15, 2017 · 11 comments

Comments

@tomer953
Copy link

*addon - skin.phenomenal
*version - 4.2.3
*url - https://github.com/tomer953/skin.phenomenal
*branch - master
*xbmc version - Krypton

Thanks, and have a nice day.

@BigNoid
Copy link
Member

BigNoid commented Apr 19, 2017

Thx for the update. Could you check the following things:

  • Invalid syntax in the English strings.po on lines 8/9 and 82.
  • Windows Line Endings detected in skin.phenomenal/extras/skinthemes/Default-Theme.theme
  • Remove skin.phenomenal/1080p/script-skinshortcuts-includes.xml

Non critical stuff you might want to optionally look into:

  • Invalid color for colordiffuse: DialogOverlayColorNF in 1080p/DialogPVRTimerSettings.xml: line 97
  • multiple instance of the easing attribute are written with a capital first letter. This tag is case sensitive and must be lower case to work.
  • All superseded xml files are still present.

@Truegatorguy
Copy link

Thanks for the info on the Krypton Phenomenal Skin. I was looking for a new build that is optimal for a Kodi media center projected on a home theater, and this might work out well. I have some questions regarding some menus I want to add, and maybe you can guide me.
I've set up a main menu, utilizing my movie library consisting of all my blu rays, but now I want to add another menu for my DVDs (separate from the Blu rays), and I also want one for the Disney films I have, separate from the blu rays and dvds. However, I can't get them to file individually -- the all want to list under the blu rays. Any idea how to create this separate widget?

Thanks for your help

Rod

@ronie
Copy link
Member

ronie commented May 9, 2017

@Truegatorguy please use the forum for support questions:
http://forum.kodi.tv/forumdisplay.php?fid=255

@ronie
Copy link
Member

ronie commented May 13, 2017

ping @tomer953 just a friendly reminder we're waiting for your response ;-)

@tomer953
Copy link
Author

@BigNoid , @ronie , thanks for pinging me.

I think that all good now, please re-check.
version has bumped to 4.2.4

@ronie
Copy link
Member

ronie commented May 17, 2017

updated, thx!
6ca08cb

@ronie ronie closed this as completed May 17, 2017
@tomer953
Copy link
Author

we have a problem...
I modified the translation files as BigNoid mentioned above,
now the file cannot be read by kodi (sorry for not checked this before PR)

"15:44:44.415 T:10768 ERROR: POParser: unable to read PO file header from file: C:\Users\Tomer\AppData\Roaming\Kodi\addons\skin.phenomenal\language\Hebrew\strings.po"

@tomer953
Copy link
Author

tomer953 commented May 18, 2017

I removed the following lines:
msgid ""
msgstr ""
from the header of the po files,
it looks like this is the cause of the problem, after I put them back everything is working fine.

but i'm not sure this is the right way
what am i missing?

@BigNoid
Copy link
Member

BigNoid commented May 18, 2017

Yes that was the invalid syntax I was talking about and those should be removed.
Sry for not communicating clearer :/

EDIT:
I will fix the repo version and bump the version.

EDIT2: Oh wait, putting them back fixes it for you? That is not right, let me check

EDIT3:
Ah yes, Kodi expect that to be the start of the strings. I will put it back and update repo version. Sry again about that. It was my mistake.

@BigNoid
Copy link
Member

BigNoid commented May 18, 2017

Fixed up with 40ca040

@tomer953
Copy link
Author

all good, thanks, will update my git too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants