fixed: window interceptor class

now we actually catch the call from the core to window update call.
xbmc · Feb 14, 2018 · 1404473 · 1404473
1 parent 4617c99
commit 1404473
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/xbmc/interfaces/legacy/WindowInterceptor.h b/xbmc/interfaces/legacy/WindowInterceptor.h
@@ -119,9 +119,6 @@ namespace XBMCAddon
     protected:
       CGUIWindow* get() override { return this; }
 
-      // this is only called from XBMC core and we only want it to return true every time
-      virtual bool Update(const String &strPath) { return true; }
-
     public:
       Interceptor(const char* specializedName,
                   Window* _window, int windowid) : P(windowid, ""),

diff --git a/xbmc/interfaces/legacy/WindowXML.cpp b/xbmc/interfaces/legacy/WindowXML.cpp
@@ -83,7 +83,7 @@ namespace XBMCAddon
       // CGUIMediaWindow
       void GetContextButtons(int itemNumber, CContextButtons &buttons) override
       { XBMC_TRACE; if (up()) CGUIMediaWindow::GetContextButtons(itemNumber,buttons); else xwin->GetContextButtons(itemNumber,buttons); }
-      bool Update(const std::string &strPath) override
+      bool Update(const std::string &strPath, bool) override
       { XBMC_TRACE; return up() ? CGUIMediaWindow::Update(strPath) : xwin->Update(strPath); }
       void SetupShares() override { XBMC_TRACE; if(up()) CGUIMediaWindow::SetupShares(); else checkedv(SetupShares()); }