Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
strip added smb:// shares of their user/pass when adding, and instead…
… store that info in the password manager
- Loading branch information
Jonathan Marshall
committed
Jul 7, 2012
1 parent
870c888
commit 16d4661
Showing
1 changed file
with
15 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16d4661
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something is wrong here, when I breakpoint here, url is already stripped off username/password I entered before and this will cause to save SaveAuthenticatedURL without them and so it will ask for username/password again even if "remeber for this path" is selected in credential dialog. Not sure what's purpose of this commit - maybe we should
if (url.GetProtocol() == "smb" && !url.GetUserName().IsEmpty())
?16d4661
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah - you're right. Should probably have some checks in SaveAuthenticatedURL() as well so we don't save it if it's actually not authenticated.