Permalink
Browse files

Fixed: [Confluence] updated the Home screen "Now Playing" media icons…

… to use Player.Art(thumb)
  • Loading branch information...
JezzX committed Oct 13, 2012
1 parent d807792 commit 217efbc6480dc77b596a5414528390b1f8aac124
Showing with 5 additions and 5 deletions.
  1. +5 −5 addons/skin.confluence/720p/Home.xml
@@ -40,7 +40,7 @@
<width>130</width>
<height>295</height>
<aspectratio aligny="bottom">keep</aspectratio>
- <texture>$INFO[MusicPlayer.Cover]</texture>
+ <texture fallback="DefaultAlbumCover.png">$INFO[Player.Art(thumb)]</texture>
<bordertexture border="8">ThumbBorder.png</bordertexture>
<bordersize>5</bordersize>
</control>
@@ -244,7 +244,7 @@
<width>150</width>
<height>300</height>
<aspectratio aligny="bottom">keep</aspectratio>
- <texture>$INFO[VideoPlayer.Cover]</texture>
+ <texture fallback="DefaultVideoCover.png">$INFO[Player.Art(thumb)]</texture>
<bordertexture border="8">ThumbBorder.png</bordertexture>
<bordersize>5</bordersize>
</control>
@@ -284,7 +284,7 @@
<width>120</width>
<height>300</height>
<aspectratio aligny="bottom">keep</aspectratio>
- <texture>$INFO[VideoPlayer.Cover]</texture>
+ <texture fallback="DefaultVideoCover.png">$INFO[Player.Art(thumb)]</texture>
<bordertexture border="8">ThumbBorder.png</bordertexture>
<bordersize>5</bordersize>
</control>
@@ -337,7 +337,7 @@
<width>120</width>
<height>300</height>
<aspectratio aligny="bottom">keep</aspectratio>
- <texture>$INFO[VideoPlayer.Cover]</texture>
+ <texture fallback="DefaultVideoCover.png">$INFO[Player.Art(thumb)]</texture>
<bordertexture border="8">ThumbBorder.png</bordertexture>
<bordersize>5</bordersize>
</control>
@@ -390,7 +390,7 @@
<width>180</width>
<height>120</height>
<aspectratio>scale</aspectratio>
- <texture>$INFO[VideoPlayer.Cover]</texture>
+ <texture fallback="DefaultVideoCover.png">$INFO[Player.Art(thumb)]</texture>
<bordertexture border="8">ThumbBorder.png</bordertexture>
<bordersize>5</bordersize>
</control>

14 comments on commit 217efbc

@wileecoyotejr

This comment has been minimized.

Show comment
Hide comment
@wileecoyotejr

wileecoyotejr Oct 13, 2012

I think this change broke the channel icons with PVR. When watching a channel and going to the home screen, it does not show the channel icon, only shows the default 'video' icon.

Same happens on the info screen while watching PVR.

Edit: Channel icons still show fine in the guide and mini guide.

I think this change broke the channel icons with PVR. When watching a channel and going to the home screen, it does not show the channel icon, only shows the default 'video' icon.

Same happens on the info screen while watching PVR.

Edit: Channel icons still show fine in the guide and mini guide.

@JezzX

This comment has been minimized.

Show comment
Hide comment
@JezzX

JezzX Oct 13, 2012

Member

I actually think this was broken before this commit because I did this too try and fix it I think the actual art stuff was the problem to begin with

Member

JezzX replied Oct 13, 2012

I actually think this was broken before this commit because I did this too try and fix it I think the actual art stuff was the problem to begin with

@wileecoyotejr

This comment has been minimized.

Show comment
Hide comment
@wileecoyotejr

wileecoyotejr Oct 13, 2012

Hmmm... I think it was working on the Oct 11th version back. I can verify that for you if you like.

Hmmm... I think it was working on the Oct 11th version back. I can verify that for you if you like.

@wileecoyotejr

This comment has been minimized.

Show comment
Hide comment
@wileecoyotejr

wileecoyotejr Oct 13, 2012

I apologize, the last version that the icons were working was this build XBMCSetup-20121010-8756dfb-master (10/10/2012). After that they were not showing correctly.

Thanks JezzX & sorry for the confusion.

I apologize, the last version that the icons were working was this build XBMCSetup-20121010-8756dfb-master (10/10/2012). After that they were not showing correctly.

Thanks JezzX & sorry for the confusion.

@JezzX

This comment has been minimized.

Show comment
Hide comment
@JezzX

JezzX Oct 13, 2012

Member

yeah maybe @jmarshallnz might have an idea why since he did all the changes on the backend code

Member

JezzX replied Oct 13, 2012

yeah maybe @jmarshallnz might have an idea why since he did all the changes on the backend code

@jmarshallnz

This comment has been minimized.

Show comment
Hide comment
@jmarshallnz

jmarshallnz Oct 13, 2012

Member

I suspect it's because only the icon is set, and perhaps this one doesn't fallback to the icon.

Try reverting 3b6c352

(This isn't a correct fix IMO, but will confirm the root cause)

Member

jmarshallnz replied Oct 13, 2012

I suspect it's because only the icon is set, and perhaps this one doesn't fallback to the icon.

Try reverting 3b6c352

(This isn't a correct fix IMO, but will confirm the root cause)

@wileecoyotejr

This comment has been minimized.

Show comment
Hide comment
@wileecoyotejr

wileecoyotejr Oct 15, 2012

@jmarshallnz, do I need to put in a request (or notify someone) to have this change (the 3b6c352 commit) reverted?

Thanks!

@jmarshallnz, do I need to put in a request (or notify someone) to have this change (the 3b6c352 commit) reverted?

Thanks!

@jmarshallnz

This comment has been minimized.

Show comment
Hide comment
@jmarshallnz

jmarshallnz Oct 15, 2012

Member

No, you need to test whether that is the problem first.

Member

jmarshallnz replied Oct 15, 2012

No, you need to test whether that is the problem first.

@wileecoyotejr

This comment has been minimized.

Show comment
Hide comment
@wileecoyotejr

wileecoyotejr Oct 15, 2012

I have no way to test. I do not have the XBMC dev environment setup. I have tried in the past, but could never get the dependencies correct to compile... Sorry :(

Im trying again now...

I have no way to test. I do not have the XBMC dev environment setup. I have tried in the past, but could never get the dependencies correct to compile... Sorry :(

Im trying again now...

@wileecoyotejr

This comment has been minimized.

Show comment
Hide comment
@wileecoyotejr

wileecoyotejr Oct 16, 2012

I have tried to build, but still unsuccessful. Can someone create a build with the 3b6c352 commit/patch reverted for me to test?

I have tried to build, but still unsuccessful. Can someone create a build with the 3b6c352 commit/patch reverted for me to test?

@jmarshallnz

This comment has been minimized.

Show comment
Hide comment
@jmarshallnz

jmarshallnz Oct 16, 2012

Member

Billy's doing one for you. It'll pop up in here in a couple hours: http://mirrors.xbmc.org/test-builds/win32/

Member

jmarshallnz replied Oct 16, 2012

Billy's doing one for you. It'll pop up in here in a couple hours: http://mirrors.xbmc.org/test-builds/win32/

@wileecoyotejr

This comment has been minimized.

Show comment
Hide comment
@wileecoyotejr

wileecoyotejr Oct 16, 2012

Thanks!

I am also in the process of trying to set up the environment on my work development machine. Hopefully I can get it set up so you don't have to go through this in the future.

Thanks!

I am also in the process of trying to set up the environment on my work development machine. Hopefully I can get it set up so you don't have to go through this in the future.

@xhaggi

This comment has been minimized.

Show comment
Hide comment
@xhaggi

xhaggi Oct 16, 2012

Member

can confirm that this commit doesn't breaks the channel icons. i have the same issue in skin aeon nox tested $INFO[VideoPlayer.Cover] and $INFO[Player.Art(thumb)] both aren't working for pvr channel icons.

Member

xhaggi replied Oct 16, 2012

can confirm that this commit doesn't breaks the channel icons. i have the same issue in skin aeon nox tested $INFO[VideoPlayer.Cover] and $INFO[Player.Art(thumb)] both aren't working for pvr channel icons.

@wileecoyotejr

This comment has been minimized.

Show comment
Hide comment
@wileecoyotejr

wileecoyotejr Oct 16, 2012

@jmarshallnz, I can confirm that the test build Billy provided does fix the channel icons. I tested with Confluence and Aeon Nox. See images below...

http://www.dotnetdevelopers.net/xbmc/images/icon1.png
http://www.dotnetdevelopers.net/xbmc/images/icon2.png
http://www.dotnetdevelopers.net/xbmc/images/icon3.png

@jmarshallnz, I can confirm that the test build Billy provided does fix the channel icons. I tested with Confluence and Aeon Nox. See images below...

http://www.dotnetdevelopers.net/xbmc/images/icon1.png
http://www.dotnetdevelopers.net/xbmc/images/icon2.png
http://www.dotnetdevelopers.net/xbmc/images/icon3.png

Please sign in to comment.