Skip to content

Commit

Permalink
Changed: [Confluence] Media "Filter" button is now an edit control in…
Browse files Browse the repository at this point in the history 
…stead of a radio button (should allow users to filter without opening the keyboard dialog if they have alphanumeric input)
  • Loading branch information
@JezzX
JezzX committed Apr 22, 2011
1 parent 6863e52 commit 259b8bf
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions addons/skin.confluence/720p/MyMusicNav.xml
View file
Expand Up @@ -72,9 +72,9 @@
<selected>Window.IsVisible(MusicLibrary)</selected>
<include>ButtonCommonValues</include>
</control>
<control type="radiobutton" id="19">
<control type="edit" id="19">
<description>Filter</description>
<textwidth>170</textwidth>
<textwidth>230</textwidth>
<include>ButtonCommonValues</include>
<label>587</label>
</control>
Expand Down
4 changes: 2 additions & 2 deletions addons/skin.confluence/720p/MyMusicSongs.xml
View file
Expand Up @@ -69,9 +69,9 @@
<include>ButtonCommonValues</include>
<enable>Library.HasContent(Music)</enable>
</control>
<control type="radiobutton" id="19">
<control type="edit" id="19">
<description>Filter</description>
<textwidth>170</textwidth>
<textwidth>230</textwidth>
<include>ButtonCommonValues</include>
<label>587</label>
</control>
Expand Down
4 changes: 2 additions & 2 deletions addons/skin.confluence/720p/MyPics.xml
View file
Expand Up @@ -74,9 +74,9 @@
<altlabel>31050</altlabel>
<usealtlabel>Container.SortDirection(Ascending)</usealtlabel>
</control>
<control type="radiobutton" id="19">
<control type="edit" id="19">
<description>Filter</description>
<textwidth>170</textwidth>
<textwidth>230</textwidth>
<include>ButtonCommonValues</include>
<label>587</label>
</control>
Expand Down
4 changes: 2 additions & 2 deletions addons/skin.confluence/720p/MyPrograms.xml
View file
Expand Up @@ -60,9 +60,9 @@
<altlabel>31050</altlabel>
<usealtlabel>Container.SortDirection(Ascending)</usealtlabel>
</control>
<control type="radiobutton" id="19">
<control type="edit" id="19">
<description>Filter</description>
<textwidth>170</textwidth>
<textwidth>230</textwidth>
<include>ButtonCommonValues</include>
<label>587</label>
</control>
Expand Down
4 changes: 2 additions & 2 deletions addons/skin.confluence/720p/MyVideoNav.xml
View file
Expand Up @@ -67,9 +67,9 @@
<altlabel>31050</altlabel>
<usealtlabel>Container.SortDirection(Ascending)</usealtlabel>
</control>
<control type="radiobutton" id="19">
<control type="edit" id="19">
<description>Filter</description>
<textwidth>170</textwidth>
<textwidth>230</textwidth>
<include>ButtonCommonValues</include>
<label>587</label>
</control>
Expand Down

2 comments on commit 259b8bf

@Hitcher
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jezz, what exactly is an 'edit' control?

The wiki has no info (http://wiki.xbmc.org/index.php?title=Edit_Control) and it's listed as a rarely control.

Also, is this a change to XBMC or just something for Confluence?

Thanks.

@JezzX
Copy link
Contributor Author

@JezzX JezzX commented on 259b8bf Apr 22, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAh its been around for a long time probably since Camelot build just never addded to the wiki I guess. Basically its a button control thats been changed so the right label is editable text (like the keyboard) so you can type straight into it when focused. If you click on it, it will still open the normal keyboard.

You can see various places jmarshall has forced it in skins like in DialogMediaSource.xml the "Source Name" button is turned into one id="12" automatically

And Yes this is just for confluence anything I put [Confluence] in the commit message is just for this skin

if you look in confluences defaults.xml you can see its pretty much just a button control with a different name

Please sign in to comment.