Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

[rbp/omxplayer] Cosmetic: Remove redundant conditional code

We are avoiding disabling ports when creating clock component, then immediately disabling ports...
  • Loading branch information...
commit 386ab440b96bd1656920902b0512ed45e4520a57 1 parent ac74d8b
@popcornmix popcornmix authored
Showing with 4 additions and 9 deletions.
  1. +0 −2  xbmc/linux/OMXClock.cpp
  2. +4 −7 xbmc/linux/OMXCore.cpp
View
2  xbmc/linux/OMXClock.cpp
@@ -131,8 +131,6 @@ bool OMXClock::OMXInitialize(CDVDClock *clock)
if(!m_omx_clock.Initialize((const std::string)componentName, OMX_IndexParamOtherInit))
return false;
- m_omx_clock.DisableAllPorts();
-
return true;
}
View
11 xbmc/linux/OMXCore.cpp
@@ -1442,14 +1442,11 @@ bool COMXCoreComponent::Initialize( const std::string &component_name, OMX_INDEX
component_name.c_str(), (int)omx_err);
}
- if(m_componentName != "OMX.broadcom.clock")
+ omx_err = DisableAllPorts();
+ if (omx_err != OMX_ErrorNone)
{
- omx_err = DisableAllPorts();
- if (omx_err != OMX_ErrorNone)
- {
- CLog::Log(LOGERROR, "COMXCoreComponent::Initialize - error disable ports on component %s omx_err(0x%08x)\n",
- component_name.c_str(), (int)omx_err);
- }
+ CLog::Log(LOGERROR, "COMXCoreComponent::Initialize - error disable ports on component %s omx_err(0x%08x)\n",
+ component_name.c_str(), (int)omx_err);
}
m_input_port = port_param.nStartPortNumber;
Please sign in to comment.
Something went wrong with that request. Please try again.