Skip to content
Browse files

[vda/vtb] - videocoreref is flipped in y direction - somehow this inf…

…luences the rendercapture image in a way that it is flipped in y too (relevant for the bookmarks and boblight). glReadPixels always returns a y flipped image - so we flip it via matrices before rendering the capture image - for corevideobuf we now skip the flip for fixing the upside down bookmarks (commented with fixme - because we still don't understand why this is affecting rendercapture at all)
  • Loading branch information...
1 parent c3cf4fb commit 7037a5d603f8903d43948ae3d7588764f142f614 @Memphiz Memphiz committed Dec 10, 2012
Showing with 9 additions and 2 deletions.
  1. +9 −2 xbmc/cores/VideoRenderers/LinuxRendererGLES.cpp
11 xbmc/cores/VideoRenderers/LinuxRendererGLES.cpp
@@ -1323,8 +1323,15 @@ bool CLinuxRendererGLES::RenderCapture(CRenderCapture* capture)
- g_matrices.Translatef(0.0f, capture->GetHeight(), 0.0f);
- g_matrices.Scalef(1.0f, -1.0f, 1.0f);
+ // fixme - we know that cvref is already flipped in y direction
+ // but somehow this also effects the rendercapture here
+ // for cvref we have to skip the flip here or we get upside down
+ // images
+ if (m_renderMethod != RENDER_CVREF)
+ {
+ g_matrices.Translatef(0.0f, capture->GetHeight(), 0.0f);
+ g_matrices.Scalef(1.0f, -1.0f, 1.0f);
+ }

0 comments on commit 7037a5d

Please sign in to comment.
Something went wrong with that request. Please try again.