Skip to content
This repository
Browse code

[vda/vtb] - videocoreref is flipped in y direction - somehow this inf…

…luences the rendercapture image in a way that it is flipped in y too (relevant for the bookmarks and boblight). glReadPixels always returns a y flipped image - so we flip it via matrices before rendering the capture image - for corevideobuf we now skip the flip for fixing the upside down bookmarks (commented with fixme - because we still don't understand why this is affecting rendercapture at all)
  • Loading branch information...
commit 7037a5d603f8903d43948ae3d7588764f142f614 1 parent c3cf4fb
Memphiz authored December 10, 2012
11  xbmc/cores/VideoRenderers/LinuxRendererGLES.cpp
@@ -1323,8 +1323,15 @@ bool CLinuxRendererGLES::RenderCapture(CRenderCapture* capture)
1323 1323
 
1324 1324
   g_matrices.MatrixMode(MM_MODELVIEW);
1325 1325
   g_matrices.PushMatrix();
1326  
-  g_matrices.Translatef(0.0f, capture->GetHeight(), 0.0f);
1327  
-  g_matrices.Scalef(1.0f, -1.0f, 1.0f);
  1326
+  // fixme - we know that cvref is already flipped in y direction
  1327
+  // but somehow this also effects the rendercapture here
  1328
+  // for cvref we have to skip the flip here or we get upside down
  1329
+  // images
  1330
+  if (m_renderMethod != RENDER_CVREF)
  1331
+  {
  1332
+    g_matrices.Translatef(0.0f, capture->GetHeight(), 0.0f);
  1333
+    g_matrices.Scalef(1.0f, -1.0f, 1.0f);
  1334
+  }
1328 1335
 
1329 1336
   capture->BeginRender();
1330 1337
 

0 notes on commit 7037a5d

Please sign in to comment.
Something went wrong with that request. Please try again.