From 8cc3b28655e7008d1a480fac4a3300145eb806c4 Mon Sep 17 00:00:00 2001 From: Philipp Kerling Date: Tue, 15 Jan 2019 12:46:52 +0100 Subject: [PATCH] [database] Log warning for MySQL < 5.5 --- xbmc/dbwrappers/mysqldataset.cpp | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/xbmc/dbwrappers/mysqldataset.cpp b/xbmc/dbwrappers/mysqldataset.cpp index 115f53ffe7b6f..231d7d06d3a83 100644 --- a/xbmc/dbwrappers/mysqldataset.cpp +++ b/xbmc/dbwrappers/mysqldataset.cpp @@ -176,8 +176,17 @@ int MysqlDatabase::connect(bool create_new) { static bool showed_ver_info = false; if (!showed_ver_info) { - CLog::Log(LOGINFO, "MYSQL: Connected to version %s", mysql_get_server_info(conn)); + std::string version_string = mysql_get_server_info(conn); + CLog::Log(LOGINFO, "MYSQL: Connected to version {}", version_string); showed_ver_info = true; + unsigned long version = mysql_get_server_version(conn); + // Minimum recommended: 5.5 + unsigned long min_version = 50500; + + if (version < min_version) + { + CLog::Log(LOGWARNING, "MYSQL: Your database server version {} is very old and might not be supported in future Kodi versions. Please consider upgrading to MySQL 5.7 or MariaDB 10.2.", version_string); + } } // disable mysql autocommit since we handle it