Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Browse files

jsonrpc: don't try to retrieve extra metadata for UPnP paths in Files…

….GetDirectory/GetFileDetails (fixes #13595)

UPnP sources can't be added to the library and they most likely already
provide nay available metadata (especially when the UPnP server is another
XBMC instance). Therefore looking for additional metadata is useless.

Furthermore calling CDirectory::Exists() on an UPnP path seems to trigger a
bug in Platinum's caching behaviour.
  • Loading branch information...
1 parent d63420e commit a8e9c49a76fd346ba3e11ad8f91aa7316a3a15b3 @Montellese Montellese committed
Showing with 4 additions and 2 deletions.
  1. +4 −2 xbmc/interfaces/json-rpc/FileOperations.cpp
6 xbmc/interfaces/json-rpc/FileOperations.cpp
@@ -128,7 +128,8 @@ JSONRPC_STATUS CFileOperations::GetDirectory(const CStdString &method, ITranspor
if ((media == "video" && items[i]->HasVideoInfoTag()) ||
(media == "music" && items[i]->HasMusicInfoTag()) ||
(media == "picture" && items[i]->HasPictureInfoTag()) ||
- media == "files")
+ media == "files" ||
+ URIUtils::IsUPnP(items.GetPath()))
if (items[i]->m_bIsFolder)
@@ -212,7 +213,8 @@ JSONRPC_STATUS CFileOperations::GetFileDetails(const CStdString &method, ITransp
return InvalidParams;
CFileItemPtr item = items.Get(file);
- FillFileItem(item, *item.get(), parameterObject["media"].asString());
+ if (!URIUtils::IsUPnP(file))
+ FillFileItem(item, *item.get(), parameterObject["media"].asString());
// Check if the "properties" list exists
// and make sure it contains the "file"

0 comments on commit a8e9c49

Please sign in to comment.
Something went wrong with that request. Please try again.