Permalink
Browse files

fixed: crash on picture load due to invalid WaitForSingleObject chang…

…e in 8c7bdfa
  • Loading branch information...
1 parent f0dd68e commit acdc0dd4d967ebd6f24453db0eefff809ac57abf @mkortstiege mkortstiege committed Jun 29, 2011
Showing with 1 addition and 1 deletion.
  1. +1 −1 xbmc/pictures/GUIWindowSlideShow.cpp
@@ -91,7 +91,7 @@ void CBackgroundPicLoader::Process()
unsigned int count = 0;
while (!m_bStop)
{ // loop around forever, waiting for the app to call LoadPic
- if (AbortableWait(m_loadPic,10) == WAIT_SIGNALED)
+ if (m_loadPic.WaitMSec(10))
{
if (m_pCallback)
{

5 comments on commit acdc0dd

Member

elupus replied Jun 29, 2011

How was the old code invalid? Looks right to me.

Member

mkortstiege replied Jun 29, 2011

The change made us crash.

Member

jmarshallnz replied Jun 29, 2011

Not sure why that would make it crash - old code looks right to me as well.

Contributor

amet replied Jun 29, 2011

crashes on OSX as well with (AbortableWait(m_loadPic,10) == WAIT_SIGNALED)

Member

jimfcarroll replied Jun 30, 2011

This was a problem with the CEventGroup which wasn't resetting the child signaled state when the wait was taking place through the group. The fix is checked in as well as undoing this change. c649019

Please sign in to comment.