Permalink
Browse files

droid: fixed missing pvr addons which are pre-installed. packagers wi…

…ll need to make extra sure there are no stale binaries manually or start with a virgin build
  • Loading branch information...
1 parent b6b24b4 commit c0ee12a8ef2cff8b6af9b17550c46a016ae3d22d @davilla davilla committed Jan 11, 2014
Showing with 1 addition and 1 deletion.
  1. +1 −1 Makefile.in
View
2 Makefile.in
@@ -556,7 +556,7 @@ ifeq ($(findstring osx,@ARCH@), osx)
else
install: install-binaries install-arch install-datas
-apk: uninstall apk-clean install
+apk: apk-clean install
make -C tools/android/packaging
apk-clean:

10 comments on commit c0ee12a

@koying
Team Kodi member

@MartijnKaijser How do we force jenkins to rebuild the dependencies?
From the logs, I understand they are only rebuilt if something changed in tools/depends, right?

@davilla

make -C tools/depends/ clean
make -C tools/depends

@koying
Team Kodi member

Mmm... Do you have access to the jenkins buildroot? I don't, afaik.Or is it for Martijn?
As the dependencies are not rebuilt each time, the pvr addons are still not packaged, because they were no rebuilt.

@Memphiz
Team Kodi member

i can force a rebuild...

@Memphiz
Team Kodi member

@koying forced rebuilds are running and will be uploaded as test-builds to the mirrors for inspection ...

@davilla

This needs to get fixed proper. it's very silly and error prone to keep ASSuming that the install location of xbmc (which overlays where pvr-addons get place) is clean and up to date. I ran into an issue then tracked it down and there was a big WTF when I looking into the install location. All sorts of ancient stuff was there.

@MartijnKaijser
Team Kodi member

On windows we clean the installation folder completely except userdata.

@t-nelson
@koying
Team Kodi member

Binary addons someone :)
Prime candidate. I don't give a damn about pvr.

@davilla

building pvr-addons with deps is not really the issue, it's more how xbmc is 'installed' into depends, then packaged from there. It really needs to get 'installled' to a temp location in packaging, then items from depends pulled over as needed. This is how darwin is packaged.

Please sign in to comment.