Skip to content
This repository
Browse code

droid: fixed missing pvr addons which are pre-installed. packagers wi…

…ll need to make extra sure there are no stale binaries manually or start with a virgin build
  • Loading branch information...
commit c0ee12a8ef2cff8b6af9b17550c46a016ae3d22d 1 parent b6b24b4
davilla davilla authored

Showing 1 changed file with 1 addition and 1 deletion. Show diff stats Hide diff stats

  1. +1 1  Makefile.in
2  Makefile.in
@@ -556,7 +556,7 @@ ifeq ($(findstring osx,@ARCH@), osx)
556 556 else
557 557 install: install-binaries install-arch install-datas
558 558
559   -apk: uninstall apk-clean install
  559 +apk: apk-clean install
560 560 make -C tools/android/packaging
561 561
562 562 apk-clean:

10 comments on commit c0ee12a

Chris Browet
Collaborator

@MartijnKaijser How do we force jenkins to rebuild the dependencies?
From the logs, I understand they are only rebuilt if something changed in tools/depends, right?

davilla
Collaborator

make -C tools/depends/ clean
make -C tools/depends

Chris Browet
Collaborator

Mmm... Do you have access to the jenkins buildroot? I don't, afaik.Or is it for Martijn?
As the dependencies are not rebuilt each time, the pvr addons are still not packaged, because they were no rebuilt.

Memphiz
Owner

i can force a rebuild...

Memphiz
Owner

@koying forced rebuilds are running and will be uploaded as test-builds to the mirrors for inspection ...

davilla
Collaborator

This needs to get fixed proper. it's very silly and error prone to keep ASSuming that the install location of xbmc (which overlays where pvr-addons get place) is clean and up to date. I ran into an issue then tracked it down and there was a big WTF when I looking into the install location. All sorts of ancient stuff was there.

Martijn Kaijser

On windows we clean the installation folder completely except userdata.

Trent Nelson
Collaborator
Chris Browet
Collaborator

Binary addons someone :)
Prime candidate. I don't give a damn about pvr.

davilla
Collaborator

building pvr-addons with deps is not really the issue, it's more how xbmc is 'installed' into depends, then packaged from there. It really needs to get 'installled' to a temp location in packaging, then items from depends pulled over as needed. This is how darwin is packaged.

Please sign in to comment.
Something went wrong with that request. Please try again.