webserver: fix crash on HTTP GET arguments without a "=" (fixes #14650)

xbmc · Oct 26, 2013 · dfbbc5e · dfbbc5e
1 parent 102219e
commit dfbbc5e
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/xbmc/network/WebServer.cpp b/xbmc/network/WebServer.cpp
@@ -22,6 +22,7 @@
 #ifdef HAS_WEB_SERVER
 #include "filesystem/File.h"
 #include "utils/log.h"
+#include "utils/StringUtils.h"
 #include "utils/URIUtils.h"
 #include "utils/Variant.h"
 #include "utils/Base64.h"
@@ -54,15 +55,21 @@ CWebServer::CWebServer()
 
 int CWebServer::FillArgumentMap(void *cls, enum MHD_ValueKind kind, const char *key, const char *value) 
 {
+  if (cls == NULL || key == NULL)
+    return MHD_NO;
+
   map<string, string> *arguments = (map<string, string> *)cls;
-  arguments->insert(pair<string,string>(key,value));
+  arguments->insert(pair<string, string>(key, value != NULL ? value : StringUtils::Empty));
   return MHD_YES; 
 }
 
 int CWebServer::FillArgumentMultiMap(void *cls, enum MHD_ValueKind kind, const char *key, const char *value) 
 {
+  if (cls == NULL || key == NULL)
+    return MHD_NO;
+
   multimap<string, string> *arguments = (multimap<string, string> *)cls;
-  arguments->insert(pair<string,string>(key,value));
+  arguments->insert(pair<string, string>(key, value != NULL ? value : StringUtils::Empty));
   return MHD_YES; 
 }
 

diff --git a/xbmc/utils/StringUtils.cpp b/xbmc/utils/StringUtils.cpp
@@ -46,6 +46,7 @@ const char* ADDON_GUID_RE = "^(\\{){0,1}[0-9a-fA-F]{8}\\-[0-9a-fA-F]{4}\\-[0-9a-
 
 /* empty string for use in returns by ref */
 const CStdString StringUtils::EmptyString = "";
+const std::string StringUtils::Empty = "";
 CStdString StringUtils::m_lastUUID = "";
 
 string StringUtils::Format(const char *fmt, ...)

diff --git a/xbmc/utils/StringUtils.h b/xbmc/utils/StringUtils.h
@@ -106,6 +106,7 @@ class StringUtils
   static bool IsInteger(const CStdString& str);
   static CStdString SizeToString(int64_t size);
   static const CStdString EmptyString;
+  static const std::string Empty;
   static size_t FindWords(const char *str, const char *wordLowerCase);
   static int FindEndBracket(const CStdString &str, char opener, char closer, int startPos = 0);
   static int DateStringToYYYYMMDD(const CStdString &dateString);