Permalink
Browse files

Fix unreachable code in GUIDialogMediaSource.cpp

Guidance on this issue is greatly appreciated.  I beleive this is
correct given how other methods in this class or implemented, but
another set of eyes is welcome.
  • Loading branch information...
1 parent bb7ba45 commit f574332197dd730cb3b0559548364a9b02c8f4f7 Kyle Hill committed with Kyle Hill Sep 6, 2012
Showing with 1 addition and 3 deletions.
  1. +1 −3 xbmc/dialogs/GUIDialogMediaSource.cpp
@@ -165,8 +165,7 @@ bool CGUIDialogMediaSource::ShowAndAddMediaSource(const CStdString &type)
bool CGUIDialogMediaSource::ShowAndEditMediaSource(const CStdString &type, const CStdString&share)
{
- VECSOURCES* pShares=NULL;
-
+ VECSOURCES* pShares = g_settings.GetSourcesFromType(type);
if (pShares)
{
for (unsigned int i=0;i<pShares->size();++i)
@@ -175,7 +174,6 @@ bool CGUIDialogMediaSource::ShowAndEditMediaSource(const CStdString &type, const
return ShowAndEditMediaSource(type,(*pShares)[i]);
}
}
-
return false;
}

0 comments on commit f574332

Please sign in to comment.