Permalink
Browse files

cleanup - no more global variables

- removed unused prototype definitions
- explicitly access the local window
- cleaned up logic, declared all implied variables
- renamed file to follow convention
- updated copyright year
  • Loading branch information...
asylumfunk committed Oct 6, 2012
1 parent 5717f40 commit fb58bfab63889bee3a3d1cc2eac14ad175e0eebd
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<addon
id="webinterface.default"
- version="2.0.5"
+ version="2.0.6"
name="Default"
provider-name="Team XBMC">
<requires>
@@ -69,6 +69,6 @@
<div id="nowPlayingPlaylist" style="display: none;"></div>
</div>
</div>
- <script type="text/javascript" src="js/xbmc.launcher.js?v=2.0.5"></script>
+ <script type="text/javascript" src="js/xbmc.launcher.js?v=2.0.6"></script>
</body>
</html>
@@ -1,91 +0,0 @@
-/*
- * Copyright (C) 2005-2011 Team XBMC
- * http://www.xbmc.org
- *
- * This Program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2, or (at your option)
- * any later version.
- *
- * This Program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with XBMC; see the file COPYING. If not, see
- * <http://www.gnu.org/licenses/>.
- *
- */
-
-/* Global Paths */
-var commsErrorTimeout;
-var JSON_RPC = 'jsonrpc';
-var DEFAULT_ALBUM_COVER = 'images/DefaultAlbumCover.png';
-var DEFAULT_VIDEO_COVER = 'images/DefaultVideo.png';
-
-/* Prototypes */
-
-String.prototype.startsWith = function(prefix) {
- return this.indexOf(prefix) === 0;
-}
-
-String.prototype.endsWith = function(suffix) {
- return this.match(suffix + "$") == suffix;
-}
-
-function durationToString(duration) {
- if (!duration) {
- return '00:00';
- }
- minutes = Math.floor(duration / 60);
- hours = Math.floor(minutes / 60);
- minutes = minutes % 60;
- seconds = duration % 60;
- var result = '';
- if (hours) {
- result += (hours < 10 ? '0' + hours : hours) + ':';
- }
- result += (minutes < 10 ? '0' + minutes : minutes) + ':' + (seconds < 10 ? '0' + seconds : seconds);
- return result;
-}
-
-function timeToDuration(time) {
- return time.hours * 3600 + time.minutes * 60 + time.seconds;
-}
-
-function applyDeviceFixes() {
- document.addEventListener('touchmove', function(e){ e.preventDefault(); });
-}
-
-function displayCommunicationError(m) {
- clearTimeout(commsErrorTimeout);
- var message = m || 'Connection to server lost';
- $('#commsErrorPanel').html(message).show();
- commsErrorTimeout = setTimeout('hideCommunicationError()', 5000);
-}
-
-function hideCommunicationError() {
- $('#commsErrorPanel').hide();
-}
-function setCookie(name,value,days) {
- if (days) {
- var date = new Date();
- date.setTime(date.getTime()+(days*24*60*60*1000));
- var expires = "; expires="+date.toGMTString();
- }
- else var expires = "";
- document.cookie = name+"="+value+expires+"; path=/";
-}
-
-function getCookie(name) {
- var nameEQ = name + "=";
- var ca = document.cookie.split(';');
- for(var i=0;i < ca.length;i++) {
- var c = ca[i];
- while (c.charAt(0)==' ') c = c.substring(1,c.length);
- if (c.indexOf(nameEQ) == 0) return c.substring(nameEQ.length,c.length);
- }
- return null;
-}
-
Oops, something went wrong.

0 comments on commit fb58bfa

Please sign in to comment.