Watch flag is not saved in cache when navigating thru python ListItems

[bigretromike]

Bug report

Describe the bug

Here is a clear and concise description of what the problem is:

When browsing thru ListItems that are crated inside addon and backing or using '..' item the 'watch flags' or 'overlays icons' are cleared. So when folder is acting as container for TvShow/Series and is marked as watched, going into it and backing up results in that ListItem not being marked anymore as watched. This affect only watched_flag.

Expected Behavior

Here is a clear and concise description of what was expected to happen:
When I enter series and go back (and Kodi use cache for it) all icons should be saved

Actual Behavior

Entering ListItem (that results in creating new one) that have icon (mark as watched) and going one level up results in the Item from ListItem loosing the icon and using default one which is square for default skin.

Possible Fix

To Reproduce

Steps to reproduce the behavior:

plugin.video.14573.v2.zip

1. install plugin
2. run plugin
3. Enter Directory > (notice that some ListItems are marked as watched) > Enter ANY listitem
4. go directory up ( by .. or backspace )
5. notice that non of listitem has mark as watched

Debuglog

The debuglog can be found here:
https://paste.kodi.tv/uyamijitim.kodi

Screenshots

Here are some links or screenshots to help explain the problem:

Additional context or screenshots (if appropriate)

Here is some additional context or explanation that might help:

Your Environment

Used Operating system:

• Android

• iOS

• Linux

• OSX

• Raspberry-Pi

• Windows

• Windows UWP

• Operating system version/name:

• Kodi version: 18.2 Git:20190422-f2643566d0, 18.3, 19.0-alpha1

note: Once the issue is made we require you to update it with new information or Kodi versions should that be required.
Team Kodi will consider your problem report however, we will not make any promises the problem will be solved.

[enen92]

Example addon?

[bigretromike]

plugin.video.nakamori but that require ShokoServer to be install on your end and minimum 1 video file.

• nakamori repo
• shokoserver

[bigretromike]

@enen92 While I was creating smaller example plugin because I understand that its not prioritet to install our setup, I came to conclusion that our code work fine with Kodi 17.
I used as base my older example that I provided to other issue: #14573 the one you kindly marked (fingers cross it will make a difference) and it looks like that code works fine on kodi18. Then I came to conclusion that our new code extend functionality and subscribe to ListItem
We are still investingating this to help pin point it while you guys investigate (or not) it.

I will update our results when we get any.

[bigretromike]

@enen92 I can confirm for not that this is related somehow to cache.
When I force my plugin into not saving into cache (it does not happened).

Also I was manage to make you a example plugin:
plugin.video.14573.zip

But for some odd reason Kodi don't want to save cache for most of the time (maybe its also some cache issue or I just don't know where Kodi really does save cache), so I manage to capture cached file:
10025-d6607184.zip
that one goes: /cache/archive_cache/10025-d6607184.fi

For unknown reason to me its hard to reproduce it on example plugin, but is easier on my main plugin.
But I was able to reproduce it after some time, and its random also. Also Kodi wipe out cache between trials.

To reproduce it try:

• going into 'directory'
• any directory
• go back

edit: v2 of this demo now reproduce this issue 100% of time

[bigretromike]

@enen92

The .fi file has 12MB (I checked the limit is set to 100MB but maybe its that 'tiny bad' thing from comment here:

xbmc/xbmc/utils/Archive.cpp

Lines 27 to 29 in 770c691

	//arbitrarily chosen, should be plenty big enough for our strings
	//without causing random bad things happening
	//not very bad, just tiny bad

The demo plugin I post above don't have that issue because the input data is not enought

I was able to make you a new demo that 100% of time does this issue without replacing cache.

plugin.video.14573.v2.zip

If I can provide you with additional help to resolve this issue fell free to ask, it super annoying to have to download over 30MB from API each time I reenter directory while using cache results in missing info.

To reproduce issue:

• install plugin
• run plugin
• Enter Directory > (notice that some ListItems are marked as watched) > Enter ANY listitem
• go directory up ( by .. or backspace )
• notice that non of listitem has mark as watched

The issue is present on both 18.3 and 19.0alpha-1

[bigretromike]

@enen92 bumping, just In case I edited post after you read it. Did the demo worked for you?

[enen92]

Hey, I did not assign myself to this issue :) Just asked for the example addon to easy the job of someone looking into investigating/fixing this.
I'll try to have a look when possible though