GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
i know this won't get much love, but i'll put it out there. :)
it allows a more visible indication if a control is disabled. especially useful in settings where skinners can not control looks with tags.
added <disabledColorDiffuse> so textures can be faded when not enabled
Haha, you're probably going to regret adding this now because it's reminded me of something that's been asked for many times in the past - Colour Diffuse per Texture.
This way we can give image controls that contain multiple textures (togglebuttons, sliders, borders, etc) their own colour diffuse thus allowing use of less textures and easier modding via color.xml.
@JezzX @ronie should this go in?
makes sense to me.
we currently only fade the label of disabled controls... the accompanying textures should be faded as well
I don't have a problem with it as long as its not required and doesn't break anything by default in current skins currently I just use the IsEnabled along with an animation
@nuka1195 mind setting the default value to 0xffffffff so current skins aren't affected when we pull this in?
m_enabledDiffuseColor seems not really needed? Already existing m_diffuseColor can store enabled diffuse color - no need to have 3 members to store 2 values.
Also - can't we just do that already using $VAR stuff?
@pieh if its not needed feel free to close it
@pieh i can't think of a way to get it to work with $VAR.
it needs a condition to check if the control is enabled or not.
control.isenabled(id) can't be used on the settings screens as we don't have those id's
what if we could use control.isenabled (without id would mean control where it is used)?
that would most certainly work