Join GitHub today
Change ratings to reflect json art (and future uniqueid) structure #10020
I have not yet implemented those but it's on Todo :)
From quick reading definition looks ok with just one caveat maybe I have not read all code.
During v17 alpha it was decided to ease JSON consumers, that breaking changes are handled with a little details.
The update to version.txt should be in a separated commit with title containing [Breaking Change] see #9300 for history.
But there's no problems for breaking changes before Beta 1.
Since this is related to something in my TODO I ask my question about it here :)
Even if there's a rating with default true, if there's a user rating it shows the user rating ?
Well maybe you should read the full discussion in #9300
This was decided and acted, because breaking changes should bump major version, but during alphas it was also decided to not bump version to avoid a too big number.
version.txt is the file that any API consumer have to look to know what PR made changes.
You can't ask someone to read 60 or 70 PR to know when the breaking change was made. Specially when JSON change is hidden in the middle of other changes.
Not indicating a breaking change in a way for API consumers to detect it is plain stupid. Period.
Please stop endless debating on acted things.
Either major version bump, or commit title on version.txt that was the choice and it was made.
userratings are a separate value in a separate field.
As long as version.txt is contained in a commit that have that tag in the tittle it's OK.
A separate commit was easier to avoid polluting the global git history to not fear everyone specially skinners.
About ratings, how do skin choose between userrating and ratings ?
Edit : To avoid spam. Ok thanks I'll guess I'll have add a setting on remote side so.
I'm no dev and I'm just guessing so please be gentle with me: