[PeripheralCecAdapter] Fix: Slovak language code (slo) considered as Slovenian (slv) #10066
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
current implementation of PeripheralCecAdapter seems to have a bug in CPeripheralCecAdapter::SetMenuLanguage implementation. As a result, when I set menu language in my TV to Slovak, it is reported via HDMI CEC to device and Kodi user interface is actually set to Slovenian.
According to HDMI specification, ISO 639-2 shall be used. For language code table please look here.
Slovak language is using ISO code slo and Slovenian is using ISO code slv. I have updated the code for both Slovak and Slovenian.
I have not yet tested this change locally, but I might do that if required. I think that because the change is actually simple, if the code builds, we should be OK.