Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PeripheralCecAdapter] Fix: Slovak language code (slo) considered as Slovenian (slv) #10066

Merged
merged 1 commit into from Jul 5, 2016
Merged

[PeripheralCecAdapter] Fix: Slovak language code (slo) considered as Slovenian (slv) #10066

merged 1 commit into from Jul 5, 2016

Conversation

vzahradnik
Copy link
Contributor

Hello,
current implementation of PeripheralCecAdapter seems to have a bug in CPeripheralCecAdapter::SetMenuLanguage implementation. As a result, when I set menu language in my TV to Slovak, it is reported via HDMI CEC to device and Kodi user interface is actually set to Slovenian.

According to HDMI specification, ISO 639-2 shall be used. For language code table please look here.

Slovak language is using ISO code slo and Slovenian is using ISO code slv. I have updated the code for both Slovak and Slovenian.

I have not yet tested this change locally, but I might do that if required. I think that because the change is actually simple, if the code builds, we should be OK.

@popcornmix
Copy link
Member

ping @opdenkamp

@stefansaraev
Copy link
Contributor

@Vladimir-Zahradnik change looks ok to me (no cec here, so cant runtime test), but you obviously should runtime test it

@stefansaraev stefansaraev added Type: Fix non-breaking change which fixes an issue Component: Input labels Jul 3, 2016
@vzahradnik
Copy link
Contributor Author

vzahradnik commented Jul 3, 2016

@stefansaraev : OK, I'll try to test the change. I will update this thread once I test my changes.

@vzahradnik
Copy link
Contributor Author

@popcornmix Could you advise how can I ping @opdenkamp? Thanks.

@popcornmix
Copy link
Member

You need to do nothing. The mention should mean he gets alerted through github notifications. He then has the option to comment here.

@opdenkamp
Copy link
Member

+1

@vzahradnik
Copy link
Contributor Author

I just tested my changes on RPi with OpenELEC (custom build). Slovak language is now set correctly based on TV language settings. I didn't have a chance to test Slovenian, because this language is not present in my TV.

Here is except from debug log:
DEBUG: SetMenuLanguage - language set to 'resource.language.sk_sk'

@popcornmix
Copy link
Member

jenkins build and merge

@jenkins4kodi jenkins4kodi merged commit 76d92ca into xbmc:master Jul 5, 2016
@vzahradnik vzahradnik deleted the bugfix-cec-slovak branch July 5, 2016 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Input Type: Fix non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants