Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xbmc/fix/filesystem] Add a recursive version of CDirectory::Remove #10206

Merged
merged 1 commit into from Aug 1, 2016

Conversation

@Paxxi
Copy link
Member

commented Jul 31, 2016

Tested on Windows and works fine
Untested on POSIX

@MilhouseVH care to try it out and see? If it builds that is :)

Tested on Windows and works
Untested on POSIX systems
@Paxxi

This comment has been minimized.

Copy link
Member Author

commented Jul 31, 2016

Jenkins build this please

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2016

Thanks Paxxi - seems to be working on Linux! The archive_cache folder is now being cleared on startup, thanks.

I did wonder if adding a boolean recurse parameter (default false) to the existing ::Remove() would be a better implementation?

@Paxxi

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2016

I hate Boolean parameters as there's no indication what they do, this is much clearer when reading

@Paxxi Paxxi added this to the Krypton 17.0-beta1 milestone Aug 1, 2016
@Paxxi Paxxi merged commit 82cc429 into xbmc:master Aug 1, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins.kodi.tv You did a great job. Have a cookie.
Details
@Paxxi Paxxi deleted the Paxxi:rmrf branch Aug 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.