Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[estuary] skin sync #10253

Merged
merged 3 commits into from Aug 15, 2016

Conversation

@BigNoid
Copy link
Member

commented Aug 7, 2016

adds the following:

  • Show channel number, channel name, episode name in second row of topbar, when playing live tv or per recordings by ksooo
  • MyPVRRecordings: Use Listitem.ActualIcon to ensure channel logo is displayed by ksooo
  • Fix for seeklabel by ronie
  • Remove media source from estuary settings window by jjd-uk
  • Adds Kodi repository as widget by HitcherUK
  • Fix timeseek label by Voyager1
  • Drop Player.SeekOffset
<param name="visible" value="!Integer.IsGreater(Container(8100).NumItems,0) + !Integer.IsGreater(Container(8200).NumItems,0) + !Integer.IsGreater(Container(8300).NumItems,0) + !Integer.IsGreater(Container(8400).NumItems,0) + !Integer.IsGreater(Container(8500).NumItems,0)"/>
<param name="button2_onclick" value="Skin.SetBool(HomeMenuNoProgramsButton)"/>
<include content="WidgetListSquare">
<param name="content_path" value="addons://repository.xbmc.org/"/>

This comment has been minimized.

Copy link
@tamland

tamland Aug 7, 2016

Member

This is an internal path, don't hardcode it in the skin. You can use addons://all/

This comment has been minimized.

Copy link
@BigNoid

BigNoid Aug 7, 2016

Author Member

The idea was to only show the add ons from our repo addons://all/ shows everything.

This comment has been minimized.

Copy link
@tamland

tamland Aug 7, 2016

Member

Why would you want it to be hardcoded to one repository?

This comment has been minimized.

Copy link
@BigNoid

BigNoid Aug 7, 2016

Author Member

I don't have a strong opinion on this. ping @HitcherUK

This comment has been minimized.

Copy link
@HitcherUK

HitcherUK Aug 7, 2016

Contributor

The idea was to promote Kodi addons only hence the heading 'Kodi Add-on Repository', all others are available through the 'Add-on browser' item at the top the screen.

@wiromare

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2016

sorry but this fix for the seeklabel has more problem then before... if you click with the mouse on the seek bar the label seeking remains visible even if you pause and unpause

the labels fast forward and rewind are shown only for a bit, then reappears the seeking label

my PR #10245 it's always there :)

@BigNoid

<value condition="!Player.DisplayAfterSeek + Player.Seeking">$LOCALIZE[773]</value>
<value condition="!String.IsEmpty(Player.SeekStepSize)">$LOCALIZE[773][COLOR=grey] $INFO[Player.SeekStepSize][/COLOR]</value>
<value condition="!String.IsEmpty(Player.SeekOffset)">$LOCALIZE[773][COLOR=grey] $INFO[Player.SeekOffset][/COLOR]</value>
<value condition="Player.Caching">$LOCALIZE[15107]</value>

This comment has been minimized.

Copy link
@FernetMenta

FernetMenta Aug 8, 2016

Member

I will drop this. caching is useless to know for the user. btw. 15107 seems to to exist.

This comment has been minimized.

Copy link
@FernetMenta

FernetMenta Aug 9, 2016

Member

disregard my comment regarding caching. sorry for confusion.

<value condition="Player.DisplayAfterSeek + ![player.forwarding | player.rewinding]">$LOCALIZE[773][COLOR=grey] $INFO[Player.SeekOffset][/COLOR]</value>
<value condition="!Player.DisplayAfterSeek + Player.Seeking">$LOCALIZE[773]</value>
<value condition="!String.IsEmpty(Player.SeekStepSize)">$LOCALIZE[773][COLOR=grey] $INFO[Player.SeekStepSize][/COLOR]</value>
<value condition="!String.IsEmpty(Player.SeekOffset)">$LOCALIZE[773][COLOR=grey] $INFO[Player.SeekOffset][/COLOR]</value>

This comment has been minimized.

Copy link
@FernetMenta

FernetMenta Aug 8, 2016

Member

drop SeekOffset, this label will disappear

@BigNoid BigNoid force-pushed the BigNoid:estuary_sync_pt3 branch from ccaf424 to aef39b2 Aug 15, 2016
@ronie

This comment has been minimized.

Copy link
Member

commented Aug 15, 2016

@wiromare those issues should be fixed now (dropping the seekoffset label).

@ronie ronie merged commit 235f4cd into xbmc:master Aug 15, 2016
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
@BigNoid BigNoid deleted the BigNoid:estuary_sync_pt3 branch Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.