Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoPlayer: fix false positive drop detection for ffmpeg decoder #10284

Merged
merged 1 commit into from Aug 14, 2016

Conversation

@FernetMenta
Copy link
Member

commented Aug 13, 2016

false positive drops results in a/v going out of sync

@fritsch mind testing this with you sample?

@fritsch

This comment has been minimized.

Copy link
Member

commented Aug 13, 2016

Via our discussion on IRC I propose to change CDVDClock::ErrorAdjust

to do an ahead correction when > 0.75 m_frametime and for the other direction by -0.75 * frametime, which will give us a band where nothing happens of 0.5 * m_frametime.

@FernetMenta FernetMenta force-pushed the FernetMenta:dropctrl branch from 2f80582 to 13abd67 Aug 13, 2016
@FernetMenta

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2016

DVDDlock::ErrorAdjust is completely disconnected from this change

@fritsch

This comment has been minimized.

Copy link
Member

commented Aug 13, 2016

@FernetMenta you asked me testing the sample from above and I did so.

@FernetMenta

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2016

@fritsch yes thanks for testing but this was before I got to know that the issue is related to clock feedback sync mode.

@FernetMenta FernetMenta added this to the Krypton 17.0-beta1 milestone Aug 13, 2016
@FernetMenta FernetMenta force-pushed the FernetMenta:dropctrl branch from 13abd67 to 9490318 Aug 13, 2016
@FernetMenta

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2016

jenkins build this please

@FernetMenta FernetMenta merged commit cd0a4aa into xbmc:master Aug 14, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins.kodi.tv You did a great job. Have a cookie.
Details
@FernetMenta FernetMenta deleted the FernetMenta:dropctrl branch Aug 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.