Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: make Peripherals a Standard setting, not Advanced #10302

Merged
merged 1 commit into from Aug 17, 2016

Conversation

@MilhouseVH
Copy link
Contributor

MilhouseVH commented Aug 16, 2016

This change will avoid this situation where new users have trouble configuring CEC which is hidden by default, as it's an "Expert" setting.

Ping @jjd-uk.

@jjd-uk

This comment has been minimized.

Copy link
Member

jjd-uk commented Aug 17, 2016

I don't see the need for this to be a Level 0 Basic setting, since the default Level on install is Level 1 Standard I would prefer any change to be to Level 1.

@MilhouseVH MilhouseVH force-pushed the MilhouseVH:peripheral_basic branch from cc32331 to 94feb08 Aug 17, 2016
@MilhouseVH MilhouseVH changed the title Settings: make Peripherals a Basic setting, not Expert Settings: make Peripherals a Standard setting, not Expert Aug 17, 2016
@MilhouseVH MilhouseVH force-pushed the MilhouseVH:peripheral_basic branch from 94feb08 to 37e0213 Aug 17, 2016
@MilhouseVH MilhouseVH changed the title Settings: make Peripherals a Standard setting, not Expert Settings: make Peripherals a Standard setting, not Advanced Aug 17, 2016
@MilhouseVH

This comment has been minimized.

Copy link
Contributor Author

MilhouseVH commented Aug 17, 2016

I assumed the default level would have been Basic, but since it's Standard I've updated the PR accordingly - thanks! Also changed the title as the current level isn't Expert, it's Advanced. Such a small change, so many mistakes. :)

@MartijnKaijser MartijnKaijser merged commit 475f3e4 into xbmc:master Aug 17, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MartijnKaijser MartijnKaijser added this to the Krypton 17.0-beta1 milestone Aug 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.