Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[estuary] revert addition of repository widget on home screen #10336

Merged
merged 1 commit into from Aug 24, 2016

Conversation

@tamland
Copy link
Member

commented Aug 24, 2016

Reverting because:
-there's no refresh logic implement
-causes 'random' modal popus on home screen
-it violate the update policy setting user has set

As mentioned in #10253 this path is solely intended for internal use in the addon browser. That's why it behaves this way. A new endpoint retrieving the repository content have to be added and designed for use in directory providers; we cant just throw arbitrary urls in it.

@BigNoid

This comment has been minimized.

Copy link
Member

commented Aug 24, 2016

If it behaves like that, yeah remove it.

@ronie

This comment has been minimized.

Copy link
Member

commented Aug 24, 2016

thanx for the explanation :)

@tamland
can you change the id on this line to 20001
4ce0d4d#diff-6a8a015fcc8e96e1ccbdc9626e1cf61eL453

@tamland

This comment has been minimized.

Copy link
Member Author

commented Aug 24, 2016

Will do!

If you've seen the various 'could not connect to repository' reports in the forums, this would be it fyi.
If nobody beats me to it I'll look into adding a proper endpoint for this, but right now I don't have a lot of spare time and there are a lot of other issues that are more important to get done first...

@tamland tamland force-pushed the tamland:revert_repo_widget branch from 4ce0d4d to d308ce0 Aug 24, 2016
@ronie ronie merged commit 1f94b1c into xbmc:master Aug 24, 2016
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.