Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[contextmenu] refactor addon loading/initialization #10356

Merged
merged 3 commits into from Aug 30, 2016

Conversation

@tamland
Copy link
Member

tamland commented Aug 28, 2016

Due to some recent refactoring every info bool for addons in the repository are registered when reading the repository index (whoops!). This should fix that and that initialization issues encountered in #10335.

@tamland tamland force-pushed the tamland:contextmenu_init branch from 5b8fc56 to d9de3a6 Aug 29, 2016
@tamland

This comment has been minimized.

Copy link
Member Author

tamland commented Aug 29, 2016

jenkins build this please

@tamland

This comment has been minimized.

Copy link
Member Author

tamland commented Aug 29, 2016

@MartijnKaijser Want to include in beta 2?
Looks like it's been causing crashes way back: http://forum.kodi.tv/showthread.php?tid=267877&pid=2402415#pid2402415

@MartijnKaijser

This comment has been minimized.

Copy link
Member

MartijnKaijser commented Aug 29, 2016

up to you :)
wanna build it tomorrow morning to release in afternoon.

@tamland

This comment has been minimized.

Copy link
Member Author

tamland commented Aug 30, 2016

Lets go for it then. Still early;)

@tamland tamland merged commit 408893b into xbmc:master Aug 30, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins.kodi.tv You did a great job. Have a cookie.
Details
@MartijnKaijser

This comment has been minimized.

Copy link
Member

MartijnKaijser commented Sep 5, 2016

Not sure if related but on a fresh install i'm getting this in the log file

22:13:14 T:18446744073034275104 ERROR: ContextMenuManager: failed to load addons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.