Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings to control notification rumble duration and strength #10370

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@garbear
Copy link
Member

commented Aug 30, 2016

I've added some fun settings that let you control the notification rumble. A forum user requested a "classier" rumble feel, so this lets people experiment with different rumble behaviours.

It might not be desirable to include these extra settings in the final build. However, I would like feedback from several people before hard-coding these values. Maybe @MilhouseVH can put out a couple builds with this patch?

rumble settings

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Aug 31, 2016

Sure, I'll add it in the next few builds. I added your latest updates in the most recent #830 build, hopefully they're working as intended (no controllers here).

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Aug 31, 2016

Ok this doesn't apply cleanly on top of #10364 (along with https://github.com/kodi-game/peripheral.joystick/pull/50) that I included in #830 so I'll drop those in order that this can be tested.

@garbear

This comment has been minimized.

Copy link
Member Author

commented Aug 31, 2016

@MilhouseVH I fixed the conflict and updated the PR. Also, I split the joystick fixes PR (#10364) into two, the second being the unrelated improvements (#10371). All three open joystick PRs should apply cleanly without conflicts.

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Aug 31, 2016

Thanks - 10364+10370+10371+PR50 all apply cleanly now. I'll try a test build and post again if there are any snags, otherwise this will all be in the next build.

@garbear

This comment has been minimized.

Copy link
Member Author

commented Aug 31, 2016

thanks for being awesome

@garbear garbear force-pushed the garbear:rumble-settings branch from 9dc4652 to 7c12fee Sep 25, 2016

@AfzalivE

This comment has been minimized.

Copy link

commented Oct 5, 2016

Any chance this will be merged into the next beta? I can help if there's something that's needed since I have interest in this PR, especially the "Rumble on notification" setting.

@garbear

This comment has been minimized.

Copy link
Member Author

commented Oct 5, 2016

No, I think I'm going to hardcode these values at 50% weak motor for 250ms. The settings are merged in my RetroPlayer builds if you want to experiment

@AfzalivE

This comment has been minimized.

Copy link

commented Oct 5, 2016

Sweet! So hopefully this gets merged to master before final Kodi 17. Thanks @garbear!! Appreciate your work. I'll check it out.

@garbear

This comment has been minimized.

Copy link
Member Author

commented Nov 14, 2016

Superseded by #10929

@garbear garbear closed this Nov 14, 2016

@garbear garbear deleted the garbear:rumble-settings branch Jun 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.