Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] linux: replace custom (sudo) install target, it's not allowed… #10382

Merged
merged 1 commit into from Sep 6, 2016

Conversation

@wsnipex
Copy link
Member

commented Sep 2, 2016

… anymore in cmake 3
fixes #16859

It isn't perfect, since cmake >=3 has restrictions on custom targets, but it should get the job done

@fetzerch @hudokkow @notspiff

@wsnipex

This comment has been minimized.

Copy link
Member Author

commented Sep 2, 2016

jenkins build addons please

@hudokkow

This comment has been minimized.

Copy link
Member

commented Sep 3, 2016

Code looks good.
Seems jenkins got stuck...

jenkins build this with addons please

… anymore in cmake 3
@wsnipex wsnipex force-pushed the wsnipex:cmake_sudo branch from b6cec58 to ebdbd5c Sep 3, 2016
@wsnipex

This comment has been minimized.

Copy link
Member Author

commented Sep 3, 2016

jenkins build this with addons please

@wsnipex

This comment has been minimized.

Copy link
Member Author

commented Sep 4, 2016

@wsnipex wsnipex merged commit 0e7de41 into xbmc:master Sep 6, 2016
2 of 4 checks passed
2 of 4 checks passed
default You are a failure. Fix the code and try again......
Details
jenkins.kodi.tv Yeah yeah I'll get to it when i have some time
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.