Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoPlayer: fix pts for passthrough audio #10383

Merged
merged 1 commit into from Sep 3, 2016

Conversation

@FernetMenta
Copy link
Member

commented Sep 2, 2016

see title

@MilhouseVH does this fix the seeking issue with passthrough enabled?

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Sep 2, 2016

No, unfortunately seeking remains the same with this PR.

I'm using this sample file: https://www.dropbox.com/s/uptq22l2nv95h7r/blechnarrisch.ts?dl=0 (streamed over smb:// or from local playback - same behaviour with both).

I am testing a build that includes #10247 and #10367 (and not LE master which is based on Kodi 17 beta1 with #10247 reverted), plus this PR.

On an Intel NUC, with passthrough enabled, seeking (step forward/step backward) will result in the seek position becoming very "jittery" (the position indicator visibly moving backwards and forwards, basically wobbling), with playback hanging and the GUI showing "100% buffering".

I see the exact same behaviour on RPi2 when using MMAL, but not when using OMX (the latter is fine, no problems).

@FernetMenta FernetMenta force-pushed the FernetMenta:leak branch from efd59fc to 9a37e32 Sep 2, 2016
@FernetMenta

This comment has been minimized.

Copy link
Member Author

commented Sep 2, 2016

should work now

@FernetMenta

This comment has been minimized.

Copy link
Member Author

commented Sep 2, 2016

jenkins build this please

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Sep 2, 2016

Yes, perfect now! Many thanks.

@FernetMenta FernetMenta merged commit a731285 into xbmc:master Sep 3, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins.kodi.tv You did a great job. Have a cookie.
Details
@FernetMenta FernetMenta deleted the FernetMenta:leak branch Sep 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.