Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[estuary] Avoid empty variables #10392

Merged
merged 1 commit into from Sep 8, 2016

Conversation

@BigNoid
Copy link
Member

commented Sep 4, 2016

Empty variables are skipped, so instead of empty use a window property Window(Home).Property(empty.value)

@ronie would this be acceptable or should core be changed to not skip an empty variable?

@ksooo this fixes the overlay issue on the parent item folder.

@ronie

This comment has been minimized.

Copy link
Member

commented Sep 4, 2016

parhaps @tamland has an idea why empty values in variables are ignored?

@BigNoid what about this approach:
ronie@75ae8fd

@tamland

This comment has been minimized.

Copy link
Member

commented Sep 4, 2016

like #10395? certainly doesn't sound right to just skip it..

@BigNoid BigNoid force-pushed the BigNoid:no_empty_vars branch from 1ad4dc2 to 1f1381d Sep 4, 2016
@BigNoid BigNoid changed the title [estuary] replace empty variable with window property [estuary] Avoid empty variables Sep 4, 2016
@BigNoid

This comment has been minimized.

Copy link
Member Author

commented Sep 4, 2016

Yep better @ronie as that's not a workaround like I had

@ronie

This comment has been minimized.

Copy link
Member

commented Sep 8, 2016

this is not really needed anymore after #10395

@phil65 think it's worth to merge it anyway?
it's a bit of a cleanup/simplification of variable values.

@phil65

This comment has been minimized.

Copy link
Member

commented Sep 8, 2016

Some of these "weird" value orders were needed when I wrote it, but that might have changed with latest @tamland changes... Might be worth it to give it a try and watch out for regressions, (especially as some change behaviour.)

@ronie ronie merged commit ac57c83 into xbmc:master Sep 8, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@BigNoid BigNoid deleted the BigNoid:no_empty_vars branch Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.