Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix skin variable parsing: dont skip if element text is empty #10395

Merged
merged 1 commit into from Sep 6, 2016

Conversation

@tamland
Copy link
Member

commented Sep 4, 2016

No description provided.

@BigNoid

This comment has been minimized.

Copy link
Member

commented Sep 4, 2016

+1 I expect it to stop if the condition is met, no matter if the value is empty. Tested and works as intended.

@ronie

This comment has been minimized.

Copy link
Member

commented Sep 4, 2016

great, thx!

@tamland

This comment has been minimized.

Copy link
Member Author

commented Sep 6, 2016

jenkins build and merge

@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Sep 6, 2016

jenkins build this please

@MartijnKaijser MartijnKaijser added this to the Krypton 17.0-beta2 milestone Sep 6, 2016
@MartijnKaijser MartijnKaijser merged commit 638ce47 into xbmc:master Sep 6, 2016
2 of 4 checks passed
2 of 4 checks passed
continuous-integration/appveyor/pr AppVeyor was unable to build non-mergeable pull request
Details
default You are a failure. Fix the code and try again......
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins.kodi.tv You did a great job. Have a cookie.
Details
@phil65

This comment has been minimized.

Copy link
Member

commented Sep 8, 2016

Late thx, this was the reason I think why I put "-" in there instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.