Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gui] use CVariant on SetVisualisation(...) #10406

Merged
merged 1 commit into from Sep 9, 2016

Conversation

@AlwinEsch
Copy link
Member

commented Sep 5, 2016

This is a part what was needed on my add-on system rework to prevent compile error, is independent and make sense for me to have.

@@ -61,7 +62,8 @@ void CGUIDialogVisualisationPresetList::SetVisualisation(CVisualisation* vis)
{
SetUseDetails(false);
SetMultiSelection(false);
SetHeading(StringUtils::Format(g_localizeStrings.Get(13407).c_str(), m_viz->Name().c_str()));
std::string heading = StringUtils::Format(g_localizeStrings.Get(13407).c_str(), m_viz->Name().c_str());
SetHeading(CVariant{heading});

This comment has been minimized.

Copy link
@Paxxi

Paxxi Sep 5, 2016

Member

Shouldn't be a need for this temporary

This comment has been minimized.

Copy link
@AlwinEsch

AlwinEsch Sep 6, 2016

Author Member

Was a c&p from the other places where it is used, thought is wanted this way ;-)

This comment has been minimized.

Copy link
@Paxxi

Paxxi Sep 6, 2016

Member

Both are fine really, when doing the original I mainly chose for readability so there's probably a mix.

@Paxxi

This comment has been minimized.

Copy link
Member

commented Sep 5, 2016

:thumbs_up: one less missing include is always a good thing

@AlwinEsch AlwinEsch force-pushed the AlwinEsch:CVariant branch from df6bff3 to bb5f951 Sep 6, 2016

@AlwinEsch

This comment has been minimized.

Copy link
Member Author

commented Sep 6, 2016

jenkins build this please

@AlwinEsch

This comment has been minimized.

Copy link
Member Author

commented Sep 9, 2016

Ok to merge in?

@Paxxi Paxxi merged commit 6d0f5ca into xbmc:master Sep 9, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins.kodi.tv You did a great job. Have a cookie.
Details

@AlwinEsch AlwinEsch deleted the AlwinEsch:CVariant branch Sep 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.