Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Estuary] fix texture paths #10415

Merged
merged 2 commits into from Sep 7, 2016

Conversation

@ronie
Copy link
Member

commented Sep 6, 2016

fixes the 'could not find texture' errors reported by @MilhouseVH

@ronie ronie referenced this pull request Sep 6, 2016
@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2016

No more errors - thanks for the quick fix!

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2016

Do you know where the following is coming from?

20:59:21 104.878525 T:1961242624   ERROR: CGUITextureManager::GetTexturePath: could not find texture 'dialogs/volume/progress/p0.png'

Edit: Maybe it's the "Buffering" indicator as that uses the volume indicator...
Edit2: Yes, it's the buffering indicator - I guess there is no 0% image

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2016

@stefansaraev it's not actually the volume indicator - if I reduce the volume to zero I get the muted image, and there is no error logged. The error being logged is from the "Buffering" overlay that appears when watching a video - at the beginning this is at 0% buffered and it obviously tries to load a non-existent 0% image.

Here: https://github.com/xbmc/xbmc/blob/master/addons/skin.estuary/1080i/VideoFullScreen.xml#L32

@stefansaraev

This comment has been minimized.

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2016

Snap. :)

I guess a blank p0.png image would be one way to solve it...

Edit: Aha, there is a p 0.png (with a space) but not a p0.png (without a space). All other single digit images include the space and no-space variants, so it looks like zero is missing the no-space version.

https://github.com/xbmc/xbmc/tree/master/addons/skin.estuary/media/dialogs/volume/progress

@ronie

This comment has been minimized.

Copy link
Member Author

commented Sep 6, 2016

yup, added.

@ronie ronie merged commit 7178ade into xbmc:master Sep 7, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ronie ronie deleted the ronie:estuary-flags branch Oct 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.