Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[autotools] Add missing APP_DATA_DIR in configure.ac #10426

Merged
merged 1 commit into from Sep 8, 2016

Conversation

@hudokkow
Copy link
Member

commented Sep 7, 2016

@MilhouseVH, please test if it solves this.

Done blindly. Don't want to play with autotools now.

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Sep 7, 2016

Many thanks, that's fixed it!

if(NOT KODI_DATA_DIR)
  set(KODI_DATA_DIR /usr/share/kodi)
endif()
@hudokkow hudokkow added the Type: Fix label Sep 7, 2016
@hudokkow

This comment has been minimized.

Copy link
Member Author

commented Sep 7, 2016

@wsnipex for sanity check.

@@ -2238,9 +2238,11 @@ fi
eval "APP_PREFIX=${prefix}"
eval "APP_LIB_DIR=${libdir}/${APP_NAME_LC}"
eval "APP_INCLUDE_DIR=${includedir}/${APP_NAME_LC}"
eval "APP_DATA_DIR=${prefix}/share/${APP_NAME_LC}"

This comment has been minimized.

Copy link
@wsnipex

wsnipex Sep 8, 2016

Member

${datarootdir}/${APP_NAME_LC}

@hudokkow hudokkow force-pushed the hudokkow:configure_APP_DATA_DIR branch from adce0c5 to b54e7f8 Sep 8, 2016
@hudokkow

This comment has been minimized.

Copy link
Member Author

commented Sep 8, 2016

Updated!

@hudokkow hudokkow added this to the Krypton 17.0-beta2 milestone Sep 8, 2016
@hudokkow hudokkow merged commit 3775244 into xbmc:master Sep 8, 2016
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@hudokkow hudokkow deleted the hudokkow:configure_APP_DATA_DIR branch Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.