Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[AddonInstaller] - 1 year and 8 month after the last recursion fix fr… #10444
…om me - lets fix the recursion again.
Well my last try worked by accident i think:
Not sure what the circular dependency was back then - but it was different.
Finally i think it makes most sense to add the current addon id whose dependencies are checked to the predeps list before checking its dependencies. Because this finally leads to the fact that we don't check an addon and its depends twice.
Reproduction of the crash as follows:
Apply this PR and see the crash goes away.
@MilhouseVH can you give this a try in libreelec please?
Well it is absolutely effing clear that tamland is absolute and doesnt care
Not for the bug fix.