Changed JpegIo thumbnail creation to use malloc/free for dest buffer #1046

Merged
merged 1 commit into from Jun 6, 2012

3 participants

@ghost

Changed JpegIo thumbnail creation to use malloc/free rather than new/delete, as libjpeg will use realloc to increase the buffer as needed. Mixing them like this could have undefined effects or cause memory leaks. This code on the xbox1 version of xbmc did indeed leak.

@joolswills joolswills Changed JpegIo thumbnail creation to use malloc/free rather than new/…
…delete, as

libjpeg will use  realloc to increase the buffer as needed. Mixing them like this could have undefined effects or cause memory leaks.
This code on the xbox1 version of xbmc did indeed leak.
55711b0
@theuni theuni was assigned Jun 5, 2012
@theuni theuni merged commit 5c9cea7 into xbmc:master Jun 6, 2012
@arnova
Team Kodi member

Nice catch :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment