Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maybe fix android crash after #10335 #10476

Merged
merged 1 commit into from Sep 17, 2016

Conversation

@tamland
Copy link
Member

commented Sep 17, 2016

untested..

@bkuhls

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2016

Thanks! I can confirm that this patch applied on top of e367347 fixes the segfault I reported in #10335 (comment)
Please note that my system is not Android, but Linux i686, so the crash seems not to be platform-dependent.

@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Sep 17, 2016

will test on android
jenkins build this please

@koying

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2016

@tamland You could keep it static and load on first ctor only if empty...
That'll avoid the member var.

@tamland

This comment has been minimized.

Copy link
Member Author

commented Sep 17, 2016

But I have no need to avoid it.. Having it as member is fine; and I get constness. I was just being lazy with the original code

@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Sep 17, 2016

@tamland tested on Android and works

@mazeyx

This comment has been minimized.

Copy link

commented Sep 17, 2016

awesome thanks guys. :)

@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Sep 17, 2016

objections?

@MartijnKaijser MartijnKaijser merged commit 2ac599b into xbmc:master Sep 17, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins.kodi.tv You did a great job. Have a cookie.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.